Toreole / BasicCombatlogParser

A small project with limited functionality in parsing WoW Combatlogs.
0 stars 1 forks source link

Akaari's Soul player association unreliable. #3

Open Toreole opened 1 year ago

Toreole commented 1 year ago

In situations where a subtlety rogue uses Secret Technique, the damage dealt by the Akaaris Soul NPC that is spawned is currently not always counted as being done by the rogue. There can be SPELL_CAST_SUCCESS events associated with these Souls, but they are unreliable when the rogue is far away from the person that is logging. In the case that they do appear however, the Advanced Parameters of the event refer to itself and subsequently provide the GUID of the rogue it belongs to. For situations where only one rogue (with the relevant talent) is in the raid, the soul can just be linked to the rogue without any additional checks, and the NpcId (144961) should be used for this.

The implementation of this will probably require a bit of a rewrite of things where special rules and such can be allowed.

Toreole commented 10 months ago

Yeah fuck it, this wont see any effort put into it, i dont care about rogues. lmfao