Toreole / BasicCombatlogParser

A small project with limited functionality in parsing WoW Combatlogs.
0 stars 1 forks source link

Use public get properties for data instead of public fields #33

Open Toreole opened 1 month ago

Toreole commented 1 month ago

As is C# standard, you shouldnt really have public fields exposed and should use get properties instead. An example of where this currently isnt the case is the DamageEvent class.

Some events are properly using properties, while some arent. This should be fixed to get the codebase all around up to standard.