Migrate from D3V to Json database.

TorgoTorgo / ghidra-findcrypt

Ghidra analysis plugin to locate cryptographic constants

https://gitlab.com/Torgo/ghidra_findcrypt

GNU General Public License v3.0

248 stars 23 forks source link

Migrate from D3V to Json database. #8

Closed clienthax closed 3 years ago

clienthax commented 3 years ago

Requires dropping ancient Ghidra versions before 9.2 due to lack of GSON library. Drops D3V support completely, doesn't seem to be maintained upstream anymore and is marked as discontinued.

https://github.com/TorgoTorgo/ghidra-findcrypt/issues/5

TorgoTorgo commented 3 years ago

Thanks! This looks great. I'll run a quick test and pull this in today. Not ideal dropping older Ghidra, but I agree, I doubt many people are pinned to those versions.

TorgoTorgo commented 3 years ago

I tested this against libsodium with the Ghidra 10.0 build and it found and labeled the crypt constants correctly.

This has been merged and pushed, not sure why GitHub didn't close this PR automatically...

TorgoTorgo commented 3 years ago

Ahh, I added a commit adding comments to a few places, looks like you did the same (apologies I should have just left the comment off as I was going to do it, didn't realise you'd be so quick!)