Torhal / Broker_Currency

A LibDataBroker display of currencies and gold totals for session / today / yesterday / this week / last week.
https://www.curseforge.com/wow/addons/broker-currency
5 stars 6 forks source link

Mod totally broken as of patch 9.1.5 #16

Closed Loredrin closed 1 year ago

Loredrin commented 2 years ago

Any chance at a fix for this mod? Or is it abandoned?

TreizeEU commented 2 years ago

This addon hasn't been updated by Torhal since version 9.0.5.7 back in April, and he doesn't appear to let us know how the rework of it was going.

For now, I've used version 9.0.2.1 and manually added missing currencies myself to the "Currencies.lua" file.

TreizeEU commented 2 years ago

Attaching my current version of above mentioned file (includin patch 9.2 PvE currencies).

EDIT: removed old file

Loredrin commented 2 years ago

Attaching my current version of above mentioned file (includin patch 9.2 PvE currencies).

Currencies.zip

Where does this file go? In the main Broker_Currency dir or the sub /currencies under it? And does it need to be renamed? I see no file named the exact same as the one you posted.

TreizeEU commented 2 years ago

First, download version 9.0.2.1, then you replace that file with the one with the same name in the main folder.

TreizeEU commented 1 year ago

Uploading my currently working version of Broker_Currency, with added currencies that I think will be used in Dragonflight (including Primeval Essence, used in this pre-patch event).

@Torhal For future reference, all I've done to this old version (9.0.2.1) of the file Broker_Currency.lua, is to comment out the following lines: 761-765, since this week's pre-patch version broke it and I don't know a better way to fix it.

houseofmabel commented 1 year ago

Uploading my currently working version of Broker_Currency, with added currencies that I think will be used in Dragonflight (including Primeval Essence, used in this pre-patch event).

Thanks so much for this!

However, I think it uses the old format pet charm, which has now been split into two:

POLISHED_PET_CHARM = 163036,
SHINY_PET_CHARM = 116415,

Obvs. these then have to be added in to ITEM_CURRENCY_IDS

Hope this helps!

TreizeEU commented 1 year ago

Good find, I fixed it in the below folder.

However I still have no idea why some item-currencies are in full caps ingame (just as they're written in the files), but they seems to work. Polished pet charm is one of them, but does appear to work.

Broker_Currency.zip

blindseerjb commented 1 year ago

Good afternoon, I installed version 9.0.2.1 and then unzipped the folder supplied by @TreizeEU however all I get from the data text is "Initializing".

TreizeEU commented 1 year ago

@blindseerjb Did you only download the zip folder I uploaded here, and unzipped where addons goes? I wonder if files from another version remains or weren't replaced as it should?

blindseerjb commented 1 year ago

@TreizeEU I first installed 9.0.2.1 and then unzipped your folder into my addons folder. Do I still need 9.0.2.1 with your folder??

TreizeEU commented 1 year ago

@blindseerjb My zipped folder should be the entire thing? Are you sure you don't have another Broker_Currency folder within the Broker_Currency folder?

blindseerjb commented 1 year ago

@TreizeEU I got it to work. I deleted the folder from 9.0.2.1 and unzipped your folder into a new Broker_Currency folder and it now appears to be working. Thank you!!

TreizeEU commented 1 year ago

@blindseerjb You're quite welcome. :)