Tormak9970 / Steam-Art-Manager

Simple and elegant Steam library customization
GNU General Public License v3.0
81 stars 2 forks source link

Not finding images #190

Closed anopem closed 2 months ago

anopem commented 2 months ago

When selecting different games the grid list says it finds no results but i have previously changed the same game with many images loading and theres plenty of images on SGDB for it aswell

This error was in console main-072727c9.js:24 Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'Capsule') at k (main-072727c9.js:24:35928)

Tormak9970 commented 2 months ago

When selecting different games the grid list says it finds no results but i have previously changed the same game with many images loading and theres plenty of images on SGDB for it aswell

This error was in console

`main-072727c9.js:24 Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'Capsule')

at k (main-072727c9.js:24:35928)`

What version is this? Is it the debug version or the latest stable release?

anopem commented 2 months ago

When selecting different games the grid list says it finds no results but i have previously changed the same game with many images loading and theres plenty of images on SGDB for it aswell This error was in console `main-072727c9.js:24 Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'Capsule')

at k (main-072727c9.js:24:35928)`

What version is this? Is it the debug version or the latest stable release?

Where would i see that? but i just updated it

edit: nvm its at the top 3.6.4

Tormak9970 commented 2 months ago

When selecting different games the grid list says it finds no results but i have previously changed the same game with many images loading and theres plenty of images on SGDB for it aswell

This error was in console

`main-072727c9.js:24 Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'Capsule')


at k (main-072727c9.js:24:35928)`

What version is this? Is it the debug version or the latest stable release?

Where would i see that? but i just updated it

edit:

nvm its at the top 3.6.4

Ok awesome. I'll look into this

Furglitch commented 2 months ago

+1 but with no console error, just [Steam Art Manager] [22:47:23] [INFO]: Query: "Wide Capsules for Skyrim Script Extender (SKSE)". Result: no grids. and similar for most games

spineduke commented 2 months ago

Facing the same issue, no images found since updating to 3.6.4

Tormak9970 commented 2 months ago

@spineduke @anopem @Furglitch I'm having trouble reproducing this after making some other fixes, so I've released those fixes in v3.6.5. Can yall test this again with the new update and let me know if the issue persists?

anopem commented 2 months ago

@spineduke @anopem @Furglitch I'm having trouble reproducing this after making some other fixes, so I've released those fixes in v3.6.5. Can yall test this again with the new update and let me know if the issue persists?

Unfortunetly it still persists for me, checked some works but didnt work for Back 4 Blood, Crysis 2 Remastered, Frostpunk, seems like the last version that works probably for me is 3.6.2

image

Tormak9970 commented 2 months ago

@spineduke @anopem @Furglitch I'm having trouble reproducing this after making some other fixes, so I've released those fixes in v3.6.5. Can yall test this again with the new update and let me know if the issue persists?

Unfortunetly it still persists for me, checked some works but didnt work for Back 4 Blood, Crysis 2 Remastered, Frostpunk, seems like the last version that works probably for me is 3.6.2

image

I'll continue to look into it. Could you try using the v3.6.4 debug release? Assuming you get the same error it'll tell us exactly where its occurring in the code

anopem commented 2 months ago

@spineduke @anopem @Furglitch I'm having trouble reproducing this after making some other fixes, so I've released those fixes in v3.6.5. Can yall test this again with the new update and let me know if the issue persists?

Unfortunetly it still persists for me, checked some works but didnt work for Back 4 Blood, Crysis 2 Remastered, Frostpunk, seems like the last version that works probably for me is 3.6.2 image

I'll continue to look into it. Could you try using the v3.6.4 debug release? Assuming you get the same error it'll tell us exactly where its occurring in the code

Heres the log tauri.localhost-1715973254539.log

Tormak9970 commented 2 months ago

@spineduke @anopem @Furglitch I'm having trouble reproducing this after making some other fixes, so I've released those fixes in v3.6.5. Can yall test this again with the new update and let me know if the issue persists?

Unfortunetly it still persists for me, checked some works but didnt work for Back 4 Blood, Crysis 2 Remastered, Frostpunk, seems like the last version that works probably for me is 3.6.2 image

I'll continue to look into it. Could you try using the v3.6.4 debug release? Assuming you get the same error it'll tell us exactly where its occurring in the code

Heres the log tauri.localhost-1715973254539.log

can you screenshot the console? this appears to be a frontend error and isn't showing up in the log file for some reason

Tormak9970 commented 2 months ago

wait nvm, misread the file

anopem commented 2 months ago

wait nvm, misread the file

From what i can tell it finds no grids in filterGrids()

Tormak9970 commented 2 months ago

yea, that's simply a filter function tho, so the main issue is likely in fetchGridsForGame() in the cache controller. I think it may be related to the page being fetched. I think I may have figured it out, need to test tho

spineduke commented 2 months ago

A bit late but also tried 3.6.5 and no luck. Doesn't pull any grids.

Tormak9970 commented 2 months ago

Its skipping the first page occassionally, which would explain why only some games don't load

anopem commented 2 months ago

Its skipping the first page occassionally, which would explain why only some games don't load

Yea that would make alot of sense ...

spineduke commented 2 months ago

You're onto something, cause the popular games do have some grids showing, so my guess is games with less than a page of grids won't return anything.

Tormak9970 commented 2 months ago

yea I figured as much, which would explain why I didn't notice it. Even the indies I have are very mainstream. I'll work on getting that fixed today, hopefully will have a fix out by the end of the day

Tormak9970 commented 2 months ago

fixed as of https://github.com/Tormak9970/Steam-Art-Manager/commit/9213bc14c9a035df53f1556d11f07b017c803881. There'll be an update available in 15 minutes or so.