search

Tormak9970 / TabMaster

Plugin for editing library tabs on the Steamdeck
GNU General Public License v3.0
37 stars 8 forks source link

[FEAT]: Integration with Emuchievements #198

Closed pawel-ch closed 4 months ago

pawel-ch commented 4 months ago

Now that we have filtering by achievement counts/percentages (https://github.com/Tormak9970/TabMaster/issues/168) maybe there's a chance to add Retro Achievements support by some kind of integration with https://github.com/EmuDeck/Emuchievements?

Tormak9970 commented 4 months ago

@KP2048 can you confirm if you modify the achievements store with EmuAchievements? I recall you mentioning something similar to that

KP2048 commented 4 months ago

Yes I do

Tormak9970 commented 4 months ago

@pawel-ch it work as it is I believe

pawel-ch commented 4 months ago

OK, I see why they weren't there. I've got the additional filter "games installed locally" (Collection filter) set in my tab and the non-steam games were excluded because of that – which is strange.

KP2048 commented 4 months ago

I modify appAchievementProgressCache, i also patch some things that aren't global

KP2048 commented 4 months ago

MetaDeck also patches the deck verified thing so filtering by that should also work

pawel-ch commented 4 months ago

I guess you can close this issue. Fastest implementation ever :grin:

I've replaced "Collection: installed locally" filter with "Installed" and it works like a charm.