search

Tormak9970 / TabMaster

Plugin for editing library tabs on the Steamdeck
GNU General Public License v3.0
35 stars 6 forks source link

[BUG]: errors on tabs using EmuDeck collections when restarting Steam #215

Open iminlikewithyou opened 2 days ago

iminlikewithyou commented 2 days ago

Describe the bug when I have a tab which references a collection - which in my case is populated by EmuDeck, there is a moment in time where the collection does not exist/was not loaded or populated yet, but TabMaster starts up and pops up an error which I can't close until i "fix" it - even though fixing it is futile because the collections already exist. i want to clarify that I don't know if this only specifically happens with EmuDeck collections - but i'm making a guess that this is probably the case.

To Reproduce Steps to reproduce the behavior:

  1. Find a collection which is created by EmuDeck
  2. Make a tab which references that collection
  3. Restart Steam in Game Mode (do not restart the Steam Deck) and hope TabMaster loads before it is created/populated/whatever
  4. Get an error

Expected behavior there are so many expected behaviors that i would so gladly enjoy:

  1. take more time before popping up an error
  2. implement a reload button on the error fix popup
  3. periodically check if the errors are fixed while the popup is open
  4. implement an ignore button or be able to close the modal (move the fixer to the plugin settings/tab settings)

Environment Info: can't get right now - i'm in bed playing in docked mode, don't want to get up, and my deck is stuck in a softlock because i restarted Steam and the plugin is holding me hostage . i'll get it later if important. Good night guys

Tormak9970 commented 2 days ago

@jessebofill thoughts on this solution:

@iminlikewithyou in regards to the other notes you made, it doesn't make sense to wait to show the modal, because if something is broken, that gives the user a chance to navigate to the tab and break their library

I'm not sure why the EmuDeck collections don't exist initially, that doesn't seem like a great method for having dynamic collections