Tormak9970 / bash-shortcuts

A Steam Deck plugin for creating custom shortcuts that can be launched from the Quick Access Menu. Uses Bash under the hood.
Other
32 stars 8 forks source link

Not launching bash shortcuts #25

Open OlegEnot opened 1 year ago

OlegEnot commented 1 year ago

Greetings! Unable to launch created shortcuts. Examples of how I tried:

bash-shortcuts.json

```javascript { "shortcuts": { "fb42129d-a7e3-4958-927b-36741f203f65": { "id": "fb42129d-a7e3-4958-927b-36741f203f65", "name": "FileBrowser", "cmd": "LD_PRELOAD= QT_SCALE_FACTOR=1.25 konsole -e /bin/bash --rcfile <(echo \"/home/deck/./runFB.sh\")", "position": 1, "isApp": false, "passFlags": false, "hooks": [] }, "71b5d674-10fc-44f1-84fa-67e6c73450a0": { "id": "71b5d674-10fc-44f1-84fa-67e6c73450a0", "name": "test", "cmd": "LD_PRELOAD= QT_SCALE_FACTOR=1.25 konsole -e \"/home/deck/./runFB.sh\"", "position": 2, "isApp": false, "passFlags": false, "hooks": [] }, "5e1c12da-090d-4317-a84f-ff358fc1dd24": { "id": "5e1c12da-090d-4317-a84f-ff358fc1dd24", "name": "test2", "cmd": "/home/deck/./runFB.sh", "position": 3, "isApp": false, "passFlags": false, "hooks": [] } }, "webSocketPort": "5000" } ```

My script from the console in desktop mode runs and functions normally (launches the binary with the keys).

bash-shortcuts.log

```shell [Bash Shortcuts] 2023-07-23 15:48:27,981 INFO [front-end]: user logged in. [DEBUG INFO] username: allqw; [Bash Shortcuts] 2023-07-23 15:48:27,983 INFO [front-end]: PluginController initializing... [Bash Shortcuts] 2023-07-23 15:48:27,985 INFO [front-end]: Services found. [Bash Shortcuts] 2023-07-23 15:48:27,986 INFO [front-end]: Services initialized. Success: true [Bash Shortcuts] 2023-07-23 15:48:28,124 INFO [front-end]: Got shortcuts. [DEBUG INFO] resultsLength: 37; [Bash Shortcuts] 2023-07-23 15:48:28,125 INFO [front-end]: WebSocket client connecting to localhost:5000... [Bash Shortcuts] 2023-07-23 15:48:28,129 INFO [front-end]: WebSocket client connected to localhost:5000. [Bash Shortcuts] 2023-07-23 15:48:28,136 INFO [front-end]: WebSocket server opened. Event: {"isTrusted":true} [Bash Shortcuts] 2023-07-23 15:48:28,143 INFO [front-end]: PluginController initialized. [Bash Shortcuts] 2023-07-23 15:48:45,244 INFO [front-end]: Reordered shortcuts. [Bash Shortcuts] 2023-07-23 15:48:45,247 INFO Setting shortcuts... [Bash Shortcuts] 2023-07-23 15:48:48,316 INFO [front-end]: Reordered shortcuts. [Bash Shortcuts] 2023-07-23 15:48:48,318 INFO Setting shortcuts... [Bash Shortcuts] 2023-07-23 15:49:34,605 INFO Modifying shortcut test [Bash Shortcuts] 2023-07-23 15:49:34,605 INFO JSON: {"id": "71b5d674-10fc-44f1-84fa-67e6c73450a0", "name": "test", "cmd": "LD_PRELOAD= QT_SCALE_FACTOR=1.25 konsole -e \"/home/deck/./runFB.sh\"", "position": 2, "isApp": false, "passFlags": false, "hooks": []} [Bash Shortcuts] 2023-07-23 15:49:54,427 INFO Modifying shortcut test2 [Bash Shortcuts] 2023-07-23 15:49:54,428 INFO JSON: {"id": "5e1c12da-090d-4317-a84f-ff358fc1dd24", "name": "test2", "cmd": "/home/deck/./runFB.sh", "position": 3, "isApp": false, "passFlags": false, "hooks": []} [Bash Shortcuts] 2023-07-23 15:49:57,176 INFO [front-end]: Reordered shortcuts. [Bash Shortcuts] 2023-07-23 15:49:57,177 INFO Setting shortcuts... [Bash Shortcuts] 2023-07-23 15:50:03,161 INFO [front-end]: Shortcut is not an app. Skipping instance shortcut creation. ShortcutId: 71b5d674-10fc-44f1-84fa-67e6c73450a0 ShortcutName: test [Bash Shortcuts] 2023-07-23 15:50:03,163 INFO [front-end]: Adding websocket listener for message type 71b5d674-10fc-44f1-84fa-67e6c73450a0 [Bash Shortcuts] 2023-07-23 15:50:03,171 INFO [front-end]: Created Instance for shortcut test [Bash Shortcuts] 2023-07-23 15:50:03,174 INFO [front-end]: Registered listener for message of type: 71b5d674-10fc-44f1-84fa-67e6c73450a0. [Bash Shortcuts] 2023-07-23 15:50:03,184 INFO [front-end]: Registering for WebSocket messages of type: 71b5d674-10fc-44f1-84fa-67e6c73450a0... [Bash Shortcuts] 2023-07-23 15:50:03,186 INFO [front-end]: Registered listener for message of type: 71b5d674-10fc-44f1-84fa-67e6c73450a0. [Bash Shortcuts] 2023-07-23 15:50:17,810 INFO [front-end]: Stopped Instance for shortcut test [Bash Shortcuts] 2023-07-23 15:50:17,812 INFO Running killInstance for shortcut with Id: 71b5d674-10fc-44f1-84fa-67e6c73450a0 [Bash Shortcuts] 2023-07-23 15:50:17,813 INFO Killing instance for test Id: 71b5d674-10fc-44f1-84fa-67e6c73450a0 [Bash Shortcuts] 2023-07-23 15:50:17,820 INFO [front-end]: Registered listener for message of type: 71b5d674-10fc-44f1-84fa-67e6c73450a0. [Bash Shortcuts] 2023-07-23 15:50:19,213 INFO [front-end]: Shortcut is not an app. Skipping instance shortcut creation. ShortcutId: 5e1c12da-090d-4317-a84f-ff358fc1dd24 ShortcutName: test2 [Bash Shortcuts] 2023-07-23 15:50:19,218 INFO [front-end]: Adding websocket listener for message type 5e1c12da-090d-4317-a84f-ff358fc1dd24 [Bash Shortcuts] 2023-07-23 15:50:19,221 INFO [front-end]: Registered listener for message of type: 5e1c12da-090d-4317-a84f-ff358fc1dd24. [Bash Shortcuts] 2023-07-23 15:50:19,224 INFO [front-end]: Created Instance for shortcut test2 [Bash Shortcuts] 2023-07-23 15:50:19,237 INFO [front-end]: Registering for WebSocket messages of type: 5e1c12da-090d-4317-a84f-ff358fc1dd24... [Bash Shortcuts] 2023-07-23 15:50:19,239 INFO [front-end]: Registered listener for message of type: 5e1c12da-090d-4317-a84f-ff358fc1dd24. [Bash Shortcuts] 2023-07-23 15:50:33,613 INFO [front-end]: Stopped Instance for shortcut test2 [Bash Shortcuts] 2023-07-23 15:50:33,615 INFO Running killInstance for shortcut with Id: 5e1c12da-090d-4317-a84f-ff358fc1dd24 [Bash Shortcuts] 2023-07-23 15:50:33,615 INFO Killing instance for test2 Id: 5e1c12da-090d-4317-a84f-ff358fc1dd24 [Bash Shortcuts] 2023-07-23 15:50:33,624 INFO [front-end]: Registered listener for message of type: 5e1c12da-090d-4317-a84f-ff358fc1dd24. [Bash Shortcuts] 2023-07-23 15:50:36,274 INFO [front-end]: Shortcut is not an app. Skipping instance shortcut creation. ShortcutId: fb42129d-a7e3-4958-927b-36741f203f65 ShortcutName: FileBrowser [Bash Shortcuts] 2023-07-23 15:50:36,277 INFO [front-end]: Adding websocket listener for message type fb42129d-a7e3-4958-927b-36741f203f65 [Bash Shortcuts] 2023-07-23 15:50:36,282 INFO [front-end]: Registered listener for message of type: fb42129d-a7e3-4958-927b-36741f203f65. [Bash Shortcuts] 2023-07-23 15:50:36,284 INFO [front-end]: Created Instance for shortcut FileBrowser [Bash Shortcuts] 2023-07-23 15:50:36,298 INFO [front-end]: Registering for WebSocket messages of type: fb42129d-a7e3-4958-927b-36741f203f65... [Bash Shortcuts] 2023-07-23 15:50:36,300 INFO [front-end]: Registered listener for message of type: fb42129d-a7e3-4958-927b-36741f203f65. [Bash Shortcuts] 2023-07-23 15:50:53,812 INFO [front-end]: Stopped Instance for shortcut FileBrowser [Bash Shortcuts] 2023-07-23 15:50:53,813 INFO Running killInstance for shortcut with Id: fb42129d-a7e3-4958-927b-36741f203f65 [Bash Shortcuts] 2023-07-23 15:50:53,813 INFO Killing instance for FileBrowser Id: fb42129d-a7e3-4958-927b-36741f203f65 [Bash Shortcuts] 2023-07-23 15:50:53,824 INFO [front-end]: Registered listener for message of type: fb42129d-a7e3-4958-927b-36741f203f65. ```

Version from the decky store - 2.0.0-1

Tell me what can be done to successfully launch from the game mode. Thank you!

ohuber commented 1 year ago

I'm having the same issue, none of my shortcuts work

Tormak9970 commented 1 year ago

I will investigate when I have a chance

ohuber commented 1 year ago

Thanks man, this plugin is awesome, i tried the testing store and the default konsole command worked a few times, but my commands just get a notification that they crashed

Linkmetal commented 1 year ago

same problem here, the default konsole command does not work at all

Tormak9970 commented 1 year ago

@ohuber @OlegEnot @Linkmetal please share what stesmOS version yall were on

Tormak9970 commented 1 year ago

@OlegEnot for you it looks like it should be marked as an app correct? If not,try marking it as one anyways. Should show the console window with the error

Tormak9970 commented 1 year ago

@Linkmetal @ohuber @OlegEnot can yall verify these issues are still present on Bash Shortcuts 2.0.4

OlegEnot commented 1 year ago

@Tormak9970 Greetings! SteamOS version 3.4.8 Just updated from the deck add-ons store (version 2.0.2), the option "cmd": "/home/deck/./runFB.sh", worked almost as expected, it starts but does not complete.

Version 2.0.4 the behavior is the same. If you set the "launch an app" flag, it starts as expected as a desktop application (due to the specifics of my script, server startup, an empty window), the option is not for me. But the completion is successful :-).

The rest of the options fail with an error, it is recommended to check the script.

Tormak9970 commented 1 year ago

@Tormak9970 Greetings! SteamOS version 3.4.8 Just updated from the deck add-ons store (version 2.0.2), the option "cmd": "/home/deck/./runFB.sh", worked almost as expected, it starts but does not complete.

Version 2.0.4 the behavior is the same. If you set the "launch an app" flag, it starts as expected as a desktop application (due to the specifics of my script, server startup, an empty window), the option is not for me. But the completion is successful :-).

The rest of the options fail with an error, it is recommended to check the script.

By complete I take it you mean it does not show the notification that it completed?

OlegEnot commented 1 year ago

@Tormak9970 Greetings! SteamOS version 3.4.8 Just updated from the deck add-ons store (version 2.0.2), the option "cmd": "/home/deck/./runFB.sh", worked almost as expected, it starts but does not complete. Version 2.0.4 the behavior is the same. If you set the "launch an app" flag, it starts as expected as a desktop application (due to the specifics of my script, server startup, an empty window), the option is not for me. But the completion is successful :-). The rest of the options fail with an error, it is recommended to check the script.

By complete I take it you mean it does not show the notification that it completed?

No, I mean that my script continued to run in the background, no exit signal was sent to the console or something like that :-)

ThisNekoGuy commented 6 months ago
  1. Installed plugin
  2. Rebooted
  3. Attempt to launch default Konsole shortcut already in the menu
  4. Fails

Was interested in this plugin but I find it hard to be convinced to fiddle with it when it seems to not work by default?