search

ToroCraft / Minecoprocessors

Increase your redstone possibilities and learn assembly programming at the same time with the Minecoprocessors Minecraft Mod!
https://minecraft.curseforge.com/projects/minecoprocessors
GNU General Public License v3.0
33 stars 10 forks source link

Fix #10 the right way #16

Closed josephcsible closed 7 years ago

josephcsible commented 7 years ago

Catching Exception is bad. Instead, just set fault if the exception would happen.

frodare commented 7 years ago

I understand the exception idealism here, but I like the little extra safety net and prefer not to crash the players game if a new bug is introduced.

josephcsible commented 7 years ago

I feel like this could be covering up stuff that causes really bad but subtle bugs. I'll try a new PR with a different approach that will just log a big warning instead of letting the game crash.