search

ToroCraft / Minecoprocessors

Increase your redstone possibilities and learn assembly programming at the same time with the Minecoprocessors Minecraft Mod!
https://minecraft.curseforge.com/projects/minecoprocessors
GNU General Public License v3.0
33 stars 10 forks source link

Why save compiled program to NBT? #48

Closed josephcsible closed 6 years ago

josephcsible commented 6 years ago

https://github.com/ToroCraft/Minecoprocessors/blob/aa3f07e9bdd9d7ddfe9f4f2e71bade279d4c1131/src/main/java/net/torocraft/minecoprocessors/processor/Processor.java#L169-L183

Is there a reason that we need to save program and labels to NBT? Instead of doing this, could we just re-parse the book whenever we load the rest of our data from NBT?

frodare commented 6 years ago

Removing that would be a good optimization. It seems like it would work without it, certainly worth a shot. Before we removing this code, let me fix the stack NBT serialization.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.