ToroCraft / Minecoprocessors

Increase your redstone possibilities and learn assembly programming at the same time with the Minecoprocessors Minecraft Mod!
https://minecraft.curseforge.com/projects/minecoprocessors
GNU General Public License v3.0
33 stars 10 forks source link

Simple Pulse Extender example doesn't work properly #64

Open Seraphaestus opened 4 years ago

Seraphaestus commented 4 years ago

The code sample for a Simple Pulse Extender given here does not work properly.

The problem appears to lie in the way the processor handles port inputs:

Doesn't work: (program never escapes loop)

cmp pb, 1
jnz start

Works:

cmp pb, 0xff
jnz start
cmp pb, 0
jz start

The processor was set up with a full strength redstone signal leading into it.

In the GUI, PB displays as in "digital mode", with a value of "0xFF 11111111b -1"

It is my impression that when the input port is in digital mode, the intended behaviour is that a non-zero redstone signal would be treated as 1b

Using minecoprocessors-1.14.4-1.0.5

stfwi commented 4 years ago

(Hi @Seraphaestus, @frodare, I quickly double checked, same in 1.12.2, I presume it's a missing sign in the example.)