search

ToroCraft / Minecoprocessors

Increase your redstone possibilities and learn assembly programming at the same time with the Minecoprocessors Minecraft Mod!
https://minecraft.curseforge.com/projects/minecoprocessors
GNU General Public License v3.0
33 stars 10 forks source link

Digital GPIOs values clamped 0x0 or 0x1. Added Input Data Register (IDR) and Output Data Register feature (ODR). #67

Closed stfwi closed 3 years ago

stfwi commented 3 years ago

Hi, @frodare, I played along a bit with additional use cases of the mod and addressed the digital mode value range in one go. The main change is adding the two registers IDR and ODR to read/write the bit encoded data words of all I/Os. That could be interesting to latch inputs as a consistent state of one tick before processing.

Also extended the manual as I have the impression people do read this prior to checking the wiki pages and need some kind of brief introduction in-game. Now, I am not a native EN, so I would feel relieved if you could risk a glimpse for typos or strange formulations.

Keep it up, cheers, wile.

stfwi commented 3 years ago

With the manual I need to check at the weekend - did you check if the words still fit on the pages or wrap? (The change in the book creator was to edit the manual while the game is running, it looks for the "manual.txt" in the game instance root folder, so closing and re-opening the book will immediately reload the changes). If you have time and like to check that, I would be glad. Cheers.

frodare commented 3 years ago

@stfwi I am not planning on working on this mod past the 1.12 master branch. Since you have done all the work getting the new versions working, I will let you decide bug fixes and features make sense. Also, please feel free to fork and rebrand the project and take it in what ever direction you want. I don't think I will be working on this in future versions and I don't want to slow your progress down.

Let me know if this PR is ready to be built. If so I will try to get it out this week.

stfwi commented 3 years ago

Hi @frodare, sorry about the late response. There are some open manual proposals by @paperky that I would like to address, but I am currently a bit short on time. Would it be acceptable to push this one up as beta and then do one release version when this is manual sorted out? I can build (and sign) the jar with the corresponding changelog if you like and attach it.

Thanks for the offer to continue the project independently for >1.12 versions. I am honestly not sure how to deal with that, as the mod is somehow mentally linked to ToroCraft in my head. As there are no massive changes planned (the IDR/ODR PR is only to enable latching all ports in one tick for a consistent dataset), I could also imagine to provide the few maintenance updates/builds for the ToroCraft Team without being mentioned, registered, or so. It's a hobby for me, and this mod is simply one of the good mods with educational value, to my brain totally underrated, and an invention in MC worth preserving (not only for "Look lad, this is how we had to code in year 19...", but more for "Look lad, this is how a machine sees it"). If I could I would to a spotlight or so.

Long tldr paragraph - Let me know what you think. Best wishes -