[Fabric] Update to Minecraft 1.20.4

[retrixe]

Includes updated Gradle, Loom, Yarn, Fabric Loader and API.

This PR includes commits for 1.19.3, 1.19.4, 1.20/1.20.1 and 1.20.2/3/4 (preferably use the "Rebase and Merge" option instead of squashing?)

Downloads: https://modrinth.com/mod/torohealth-damage-indicators-updated

[PRRB]

Works for me. Thx.

[papertek]

1.19.2?

[retrixe]

1.19.2?

The current version on CurseForge already works on 1.19.2.

[kkellogg378]

1.19.4 only partially works. Makes the in-game GUI green though

[brunociria]

@kkellogg378 how did you manage to make 1.19.4 work? I tested with the latest fabric version + latest fabric api and It crashes when looking at mobs. I also tested on quilt and I have the same issue.

[kkellogg378]

@kkellogg378 how did you manage to make 1.19.4 work? I tested with the latest fabric version + latest fabric api and It crashes when looking at mobs. I also tested on quilt and I have the same issue.

Unsure. I did run it alongside Sodium and Starlight though, so rendering might have been better.

Either way, looking at a mob made it laggier and the GUI was all green, so it doesn't work well

[retrixe]

I'm not sure how the GUI was green and caused fps lag for you, the 1.19.3 version crashed for me with Sodium, Starlight and some other mods like Lithium/Iris/etc, just like the previous user i.e. whenever looking at mobs.

Anyway, I have pushed a 1.19.4 updated version which you can test and see if you have the same issue.

[kkellogg378]

I usually disable the HUD "showEntity" "showBar" and "showSkin" and set the inWorld "mode" to ALWAYS, and the new 1.19.4 one still changes the item I'm holding to be green (on the bright side, the hotbar is correctly colored now).

Note: I did test this with just Fabric API and Torohealth enabled, the same thing happens. Also, looking at a hostile enemy makes the held item look red

EDIT: Also no fps issues this time. I think last time my computer was just having a bad day

[retrixe]

I was able to reproduce this issue, I have updated the download JAR with a version that fixes it for me (i.e. the above commit)

[kkellogg378]

Works great now! Thank you!

[Annijang]

Includes updated Gradle, Loom, Yarn, Fabric Loader and API.

This PR includes commits for both 1.19.3 and 1.19.4 (preferably use the "Rebase and Merge" option instead of squashing?)

Downloads (uploaded as ZIP cause GitHub doesn't allow JAR uploads):

• 1.19.3 version: torohealth-1.19.3-fabric-1.zip
• 1.19.4 version: torohealth-1.19.4-fabric-1.zip

hi, can you please do 1.19.2forge, 1.19.3forge, 1.19.4forge? Thanks.

[retrixe]

hi, can you please do 1.19.2forge, 1.19.3forge, 1.19.4forge? Thanks.

Sorry, I don't have experience with Forge development. I could look into it in the future if I have spare time, but it's very unlikely since I have a lot of my own projects and work, hopefully someone else can step in to update the Forge version.

[Annijang]

hi, can you please do 1.19.2forge, 1.19.3forge, 1.19.4forge? Thanks.

Sorry, I don't have experience with Forge development. I could look into it in the future if I have spare time, but it's very unlikely since I have a lot of my own projects and work, hopefully someone else can step in to update the Forge version.

Can you make a version of 1.20 when it comes out? Thank you, forget it if you can't forge, it's ok.

[HowardZHY]

now 1.20.1 when

[fijidarko]

Any update for 1.20 happening?

[retrixe]

Minecraft changed rendering a fair bit in 1.20, I have a partial port locally but there's some bugs before I can push it. No ETA

[retrixe]

Done, and seems to work without any issues :tada:

[Kxsumi]

W

[HowardZHY]

Done, and seems to work without any issues 🎉

I think you may publish it as ToroHealth Unoffical on Modrinth

[mbassie]

Bars are working, but can't seem to get the damage particles on screen on 1.20. Still using Iris/Sodium etc.

[ZsoltMolnarrr]

Hey @retrixe ! Installed the 1.20.1 version alongside Sodium and Iris. The damage indicator particles don't show at all. Could you please fix it?

[MC-Gary003]

Forge? 1.20.1?

[ZsoltMolnarrr]

1.20.1 Fabric, where the damage particles don’t work fully. Maybe it’s the same for Forge, haven’t tested it.

[MC-Gary003]

But where's FORGE

[retrixe]

Damage particles for me do work with shaders off in Iris/Sodium, but with shaders on in Iris, they don't work, and I'm not sure why.. I don't have any expertise wrt rendering in Minecraft and the code seems ok to me so I'm not sure where to start to get to the bottom of this issue.

Forge? 1.20.1?

I already made it clear here https://github.com/ToroCraft/ToroHealth/pull/171#issuecomment-1575592333

[wsxiya]

Why are damage numbers black?

[gitguette]

Why are damage numbers black?

same, the bar also doesn't show up.

[coolGi69]

Got my own fork for forge 1.20.1 at: https://github.com/coolGi2007/ToroHealth/tree/forge-1.20.1

torohealth-1.20.1-forge-1.zip

[lxly9]

Hiya, using version 1.20.1 fabric and im not getting the in-world bar to show up. This is my config which should work fine (its essentially the same as in 1.19.2)

[MrOz59]

same here, in world bars don't appear

[qguo-gid]

anyone know who to config the bar in the mod to hearts? this is for 1.20.1 version

[retrixe]

@lxly9 I just tried the 1.20.1 version and health bars are working fine with Sodium+Iris (shaders enabled and disabled) and vanilla configurations Can you let me know what mods you're running?

@qguo-gid I'm not sure there is such a feature, I haven't added any features to the mod and just updated it as-is

[MrOz59]

@lxly9 I just tried the 1.20.1 version and health bars are working fine with Sodium+Iris (shaders enabled and disabled) and vanilla configurations Can you let me know what mods you're running?

@qguo-gid I'm not sure there is such a feature, I haven't added any features to the mod and just updated it as-is

I don't know which ones lxly9 is using, but I have a lot of mods, full list here: https://pastebin.com/gLY2dx5D

[retrixe]

These are a lot of mods which unfortunately I can't sift through and test myself, I advise trying a binary search (remove half the mods and see if the bug persists) to narrow down any potential conflicts with other mods?

[BoardAnims]

In 1.20.1 Forge, the damage numbers display black, no matter if the color values are changed in the config files...

[Jszp03]

Can you add mobs to blacklist?

Cobblemon mobs is incompatible because all cobblemons have different health system, and it already includes healthbars for them so it overlaps

[ditt0132]

what about 1.21? someone have a progress? or i can try