Heroku support - Githubissues

Torom commented 2 years ago

Thanks for the PR. I know the possibility to use Dockerfiles for Heroku. But I would just download the latest stockfish version and not compile it myself. I would also prefer to use Docker for Heroku, however there are two things that keep me from doing so:

As far as I know, the Heroku CLI is required to use Docker and I don't have the feeling that all users can do that.
How do I get the Lichess token into the container properly? That shouldn't be a big problem, though.

btw: When you create a PR it would be good to add an explanation, what is the purpose of the PR, how will it be implemented and why should it be implemented.

RaviharaV-bot commented 2 years ago

it can get lichess token from config.yml or it can get from an environment variable like in this https://github.com/ShailChoksi/lichess-bot/blob/bfcbbd3e68095d80758fcc4424ec6baed545c833/config.py#L18 I will add an explanation

Torom commented 2 years ago

Okay, if this works with the environment variable everything is fine. I don't want to tell my users to post their token publicly on GitHub.

Torom commented 2 years ago

I have added my own version with 88336a5. Thanks again for your PR.

Torom / BotLi

Heroku support #11