Torom / BotLi

Lichess Bot
GNU Affero General Public License v3.0
44 stars 82 forks source link

Better security for deploying in heroki #12

Closed Adventuresofbot closed 2 years ago

Adventuresofbot commented 2 years ago

Before @Torom already did how to deploy using action but I think it is not fully safe as it leak our mail adress thought that one is fast but still not secure This one is full secure and no one able to leak or see your mail adress

Torom commented 2 years ago

That was the way I done it before. But it has two major disadvantages:

I understand that publishing the email address is unwanted. But this is quite simple to prevent. I will change this and then you are welcome to test it.

Torom commented 2 years ago

With 16a86a8 you don't save the email in the main.yml, instead you have to add another secret with your email in your github repository. Please test it and report back.

Adventuresofbot commented 2 years ago

Then I think with your main we can also private heroku app And that way we dont have to edit main.yml

Torom commented 2 years ago

Yes that would be possible. But first, the app name is not a secret. And secondly, the user has to push a change anyway to trigger the first deploy. So I don't want to change that.

Adventuresofbot commented 2 years ago

Yes u r correct

Torom commented 2 years ago

If this solves your problem, you can close the PR and the issue.