Torom / BotLi

Lichess Bot
GNU Affero General Public License v3.0
46 stars 82 forks source link

Request: Specific white and black books for each TC #132

Closed IbaiBuR closed 1 year ago

IbaiBuR commented 1 year ago

Is your feature request related to a problem? Please describe. No its not, it is something I'd like to see implemented to increase the strength of my bots

Describe the solution you'd like As of now, with all the new changes, we can select books for standard, white, black, bullet, blitz, rapid...

But, in my case, I'd like to be able to choose different books for white and black for an specific TC, in this way:

bullet:
  white:
     names:
      ....
  black: 
     names:
     ....

Hope this is not very annoying and does not complicate the config too much. Thanks in advance

Torom commented 1 year ago

I don't particularly like the way white and black books are defined so far either. The programming effort is also not very complex. But I'm not sure how to get it into the config. The goal is that a simple configuration is still possible. Your proposed structure would bloat the config too much and a simple configuration would not be so trivial anymore. So someone who just wants to use a book for all cases for example.

I am open for suggestions.

Torom commented 1 year ago

Something like TC_COLOR as key would make sense, but don't know yet if this is the best solution and if the users really get along with it. This would look something like this:

  books:
    standard:
      selection: weighted_random
      names:
        - DefaultBook
    bullet_white:
      selection: weighted_random
      names:
        - WhiteBook
    bullet_black:
      selection: weighted_random
      names:
        - BlackBook

EDIT: The more I think about it, the more I like the idea. We could use a separator other than the _ if that is somehow better. I would like to hear the user perspective here. Maybe @EmptikBest can comment on this.

IbaiBuR commented 1 year ago

I am glad that you like the idea actually :).

In this way for example you can use riskier books with higher TCs such as rapid or classical for example and leave the best books for bullet and blitz.

Yeah, you are right, in the way I proposed it the config starts to be far from trivial. The way you proposed it seems to be a lot better and using TC_COLOR as key can be a way of implementing it.

I think using _ as separator is also fine, but as you say we can let some people to comment on it before any changes are made.

IbaiBuR commented 1 year ago

Great, thanks!

EmptikBest commented 1 year ago

Something like TC_COLOR as key would make sense, but don't know yet if this is the best solution and if the users really get along with it. This would look something like this:

  books:
    standard:
      selection: weighted_random
      names:
        - DefaultBook
    bullet_white:
      selection: weighted_random
      names:
        - WhiteBook
    bullet_black:
      selection: weighted_random
      names:
        - BlackBook

EDIT: The more I think about it, the more I like the idea. We could use a separator other than the _ if that is somehow better. I would like to hear the user perspective here. Maybe @EmptikBest can comment on this.

Yes, I would like it too! Glad to see this added 👍