search

Toron5 / Object-orientated-assignment-1

0 stars 0 forks source link

Code Review - Gareth Mason #1

Open GMWolf1988 opened 2 years ago

GMWolf1988 commented 2 years ago

1) Is the code properly documented/commented?

Overall good code structure and well commented. Instances and methods called correctly. Checklist is near completion. Custom classes and methods could be implemented - example: have a Choice method and class to handle all user choices, to tick this off the checklist.

2) Does the code handle errors properly?

Code handles errors and captures them well. Only criticism - when code is asking for user to print 'long text file', if any other input is given instead of 'Y/N', program restarts back to the beginning rather than stating an error was made.

3) What suggestions do you have to improve the code

Error handling for user input and custom classes as stated would improve the code. However the code is presented well and commented efficiently to a high standard.

Toron5 commented 2 years ago

Thank you for the feedback it was very helpful I have created a new custom class to handle the Longword file requests and made sure it doesn't loop on an erroneous input.