Some SQLFluff annotations are sometimes not annotated

Nate-Wessel commented 7 months ago

Some SQLFluff failures are not resulting in an annotation. In most/all cases, it seems like the failure is straightforwardly corresponding to a single line, i.e. it's nothing crazy complicated and doesn't seem like it's only effecting edges cases.

For example:

== [collisions/2024-01-19_i0581_Collisions_red-light_camera_group/i0581_rlc_collision_statistics.sql]
FAIL
L:  26 | P:   1 | LT08 | Blank line expected but not found after CTE closing
                       | bracket. [layout.cte_newline]

The action fails, but it doesn't give any feedback as to why.

I don't know why this is happening. I haven't see much of a pattern to it yet.

Nate-Wessel commented 4 months ago

Just created https://github.com/yuzutech/annotations-action/issues/68

I think I was seeing these as single-line annotations in the human-readable output from SQLFluff, but in the github annotations file, they were actually multi-line.

Nate-Wessel commented 4 months ago

Context on what these annotation output formats actually are: https://github.com/sqlfluff/sqlfluff/issues/3106

Apparently this ONLY works with this specific action, and only partially at that.

But the other format also has some pretty major limitations! https://github.com/sqlfluff/sqlfluff/issues/3857

Toronto-Big-Data-Innovation-Team / .github

Some SQLFluff annotations are sometimes not annotated #9