Torrunt / vimage

A simplistic image viewer for Windows, inspired by vjpeg.
https://torrunt.net/vimage
MIT License
102 stars 13 forks source link

Video Support #26

Closed Torrunt closed 8 years ago

Torrunt commented 9 years ago

Finishing adding Video Support via Windows Media Player

Initial commit adding support for videos: https://github.com/Torrunt/vimage/commit/4cc90439ade0f8022db0db36183d965a025d303d

whisperity commented 9 years ago

I think you should start working this out on a separate branch and not upon the stable master. :smile:

Torrunt commented 9 years ago

Yeah, I was thinking that. Maybe I will, though it doesn't really affect the normal program at all. There's only problems if you open a video.

I was originally planning on just getting it all done then committing it but I haven't done anything with it for awhile :P.

whisperity commented 9 years ago

Although this is really not related to the issue, this is something I have to ask. I have been using vimage for... (checks reflog) way more than a year now, and it became (at least for me) the WinAMP for images. The issue I'm pressing is that: wouldn't implementing support like that (for videos, etc.) slowly make it turn into a bloatware? :frowning:

I sincerely think this is a useless addition as there are plenty of very good video players out there, take VLC for example. (VLC is a must-have program on every computer!)

Torrunt commented 9 years ago

Well I wanted to add it because a lot of people are using webm/mp4 for short looped animation these days instead of animated gifs. I wanted to be able to open those in vimage and have them act just like animated gifs.

The video viewer is separate from the regular image viewer so it shouldn't really bulk down the program at all. I could try and make it so all the video functionality is in a separate class library entirely and if someone doesn't want to use the video support at all they can just disable it in the options and delete the dll for it.

Also, I just moved that last commit with video support to a different branch by the way.