Google Plus SDK v1.3.0 crashed when saving keychain name.

GoogleCodeExporter commented 9 years ago

Google Plus SDK v1.3.0 crashed with the following stack:
-[__NSArrayM insertObject:atIndex:]: object cannot be nil
-[__NSArrayM insertObject:atIndex:] + 768
-[GPPSignIn addSavedKeychainName:]
-[GPPSignIn didFinishTokenFetchWithAuth:fetcher:error:]
+[GTMOAuth2Authentication invokeDelegate:selector:object:object:object:]
-[GTMOAuth2Authentication tokenFetcher:finishedWithData:error:]
-[GTMHTTPFetcher invokeFetchCallback:target:data:error:]
-[GTMHTTPFetcher invokeFetchCallbacksWithData:error:]
-[GTMHTTPFetcher connectionDidFinishLoading:]

How does the product behaviour differ from your expectations?
SDK shouldn't crash. it should return an error.

Describe, step-by-step, how to reproduce this issue.
dont know the scenario.

Describe the impact of this bug
Application crashed!

-> How many users does this bug impact? 
44 users per day

What is the size of your user base
and what percentage of your user base is impacted?

When did this bug start happening?
it happens in 1.3.0. don't know if happened before that.

When does the bug occur?
intermittently.
44 users per day.

Original issue reported on code.google.com by a...@magisto.com on 21 Jun 2013 at 1:58

GoogleCodeExporter commented 9 years ago

To fix this bug, we need to be able to reproduce it. Can you provide any 
additional information about what triggered the bug?

Original comment by joannasm...@google.com on 15 Jul 2013 at 8:34

Changed state: Pending
Added labels: Component-Quick-Start
Removed labels: Component-REST-API

GoogleCodeExporter commented 9 years ago

I am also facing this issue. 

here is a crash log

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x22200a83
Crashed Thread:  0

Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   libobjc.A.dylib                 0x31545fbc objc_msgSend + 16
1   Instant-Encounter               0x00367af2 -[GTMHTTPFetcher 
invokeFetchCallbacksWithData:error:] (GTMHTTPFetcher.m:966)
2   Instant-Encounter               0x00369010 -[GTMHTTPFetcher 
connectionDidFinishLoading:] (GTMHTTPFetcher.m:1270)
3   Foundation                      0x319c1c32 __65-[NSURLConnectionInternal 
_withConnectionAndDelegate:onlyActive:]_block_invoke_0 + 10
4   Foundation                      0x319196e2 
-[NSURLConnectionInternalConnection invokeForDelegate:] + 22
5   Foundation                      0x319196ac -[NSURLConnectionInternal 
_withConnectionAndDelegate:onlyActive:] + 192
6   Foundation                      0x319195ce -[NSURLConnectionInternal 
_withActiveConnectionAndDelegate:] + 54
7   CFNetwork                       0x36f4689e 
URLConnectionClient::_clientDidFinishLoading(URLConnectionClient::ClientConnecti
onEventQueue*) + 186
8   CFNetwork                       0x36f3b53e 
URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePaylo
ad(XConnectionEventInfo<XClientEvent, XClientEventParams>*, long) + 418
9   CFNetwork                       0x36f3b632 
URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePaylo
ad(XConnectionEventInfo<XClientEvent, XClientEventParams>*, long) + 662
10  CFNetwork                       0x36f3b23c 
URLConnectionClient::processEvents() + 100
11  CFNetwork                       0x36f3b172 MultiplexerSource::perform() + 150
12  CoreFoundation                  0x37a39afc 
__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 8
13  CoreFoundation                  0x37a392c8 __CFRunLoopDoSources0 + 208
14  CoreFoundation                  0x37a3806e __CFRunLoopRun + 646
15  CoreFoundation                  0x379bb4d6 CFRunLoopRunSpecific + 294
16  CoreFoundation                  0x379bb39e CFRunLoopRunInMode + 98
17  GraphicsServices                0x37539fc6 GSEventRunModal + 150
18  UIKit                           0x34e4b73c UIApplicationMain + 1084
19  Instant-Encounter               0x000b301c main (main.m:13)
20  Instant-Encounter               0x00007200 start + 32

Original comment by wadhwa.s...@gmail.com on 23 Aug 2013 at 12:38

GoogleCodeExporter commented 9 years ago

Fatal Exception NSInvalidArgumentException
*** -[__NSArrayM insertObject:atIndex:]: object cannot be nil
0
CoreFoundation   __exceptionPreprocess + 130
1
libobjc.A.dylib  objc_exception_throw + 38
2
CoreFoundation   CFStringConvertNSStringEncodingToEncoding
3
yerdle   -[GPPSignIn addSavedKeychainName:]
4
yerdle   -[GPPSignIn didFinishTokenFetchWithAuth:fetcher:error:]
5
CoreFoundation   __invoking___ + 68
6
CoreFoundation   -[NSInvocation invoke] + 282
7
yerdle   +[GTMOAuth2Authentication invokeDelegate:selector:object:object:object:]
8
yerdle   -[GTMOAuth2Authentication tokenFetcher:finishedWithData:error:]
9
CoreFoundation   __invoking___ + 68
10
CoreFoundation   -[NSInvocation invoke] + 282
11
yerdle   -[GTMHTTPFetcher invokeFetchCallback:target:data:error:]
12
yerdle   -[GTMHTTPFetcher invokeFetchCallbacksWithData:error:]
13
yerdle   -[GTMHTTPFetcher connectionDidFinishLoading:]
14
Foundation   __65-[NSURLConnectionInternal 
_withConnectionAndDelegate:onlyActive:]_block_invoke + 54
15
Foundation   -[NSURLConnectionInternal _withConnectionAndDelegate:onlyActive:] + 
206
16
Foundation   -[NSURLConnectionInternal _withActiveConnectionAndDelegate:] + 60
17
CFNetwork    
___ZN27URLConnectionClient_Classic26_delegate_didFinishLoadingEU13block_pointerF
vvE_block_invoke + 74
18
CFNetwork    
___ZN27URLConnectionClient_Classic18_withDelegateAsyncEPKcU13block_pointerFvP16_
CFURLConnectionPK33CFURLConnectionClientCurrent_VMaxE_block_invoke_2 + 54
19
CFNetwork    
___ZNK17CoreSchedulingSet13_performAsyncEPKcU13block_pointerFvvE_block_invoke + 
18
20
CoreFoundation   CFArrayApplyFunction + 36
21
CFNetwork    RunloopBlockContext::perform() + 164
22
CFNetwork    MultiplexerSource::perform() + 220
23
CFNetwork    MultiplexerSource::_perform(void*) + 48
24   CoreFoundation  __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 
+ 14
30   UIKit   UIApplicationMain + 1136
31
yerdle  
main.m line 16
main
32
libdyld.dylib    start + 2

Original comment by hugues.b...@gmail.com on 20 Nov 2013 at 10:10

GoogleCodeExporter commented 9 years ago

Same thing appears here.

Fatal Exception NSInvalidArgumentException
*** -[__NSArrayM insertObject:atIndex:]: object cannot be nil
raw
0   CoreFoundation   __exceptionPreprocess + 162
1   libobjc.A.dylib  objc_exception_throw + 30
2   CoreFoundation   -[__NSArrayM insertObject:atIndex:] + 768
3   ProjectName      -[GPPSignIn addSavedKeychainName:]
4   ProjectName  -[GPPSignIn didFinishTokenFetchWithAuth:fetcher:error:]
5   CoreFoundation   __invoking___ + 68
6   CoreFoundation   -[NSInvocation invoke] + 286
7   ProjectName  +[GTMOAuth2Authentication 
invokeDelegate:selector:object:object:object:]
8   ProjectName  -[GTMOAuth2Authentication tokenFetcher:finishedWithData:error:]

Original comment by michal.z...@twobits.cz on 26 Nov 2013 at 11:11

GoogleCodeExporter commented 9 years ago

Great support from Google Plus on this bug...

We need to reproduce it..

Can you just always check that an object is not nil before adding it to an 
array?

Original comment by hugues.b...@gmail.com on 5 Feb 2014 at 2:30

Torsten2217 / google-plus-platform

Google Plus SDK v1.3.0 crashed when saving keychain name. #602