TorstenDittmann / OmniaWrite

A text editor engineered for creative writing.
https://OmniaWrite.com
Apache License 2.0
161 stars 34 forks source link

Some strings are not displayed in Spanish #93

Closed dennistobar closed 4 years ago

dennistobar commented 4 years ago

Describe the bug After create a new Scene, the string Let's write an awesome story! and the dialog to confirm delete a paragraph are displayed in English.

To Reproduce Steps to reproduce the behavior:

  1. Change the language to Spanish
  2. Click on New Scene (when is available)
  3. See the string in new page

Expected behavior Show the string "¡Vamos a escribir una historia asombrosa!" and "¿Estás seguro?"

Screenshots Captura de pantalla de 2020-09-24 22-32-40 Captura de pantalla de 2020-09-24 22-32-25

Desktop (please complete the following information):

Additional context I think the problem is in omnia-editor maybe here, I'm unsure about that, and I can read TypeScript but I can't write code fluently.

TorstenDittmann commented 4 years ago

Good catch!

This is actually implemted and I missed 2 strings. There is a i18n store ($i18n.placeholder is the variable for example) that is being handed the translation from OmniaWrite. It just needs to have the correct variable set: https://github.com/TorstenDittmann/omnia-editor/blob/master/src/Editor.svelte#L116 https://github.com/TorstenDittmann/omnia-editor/blob/master/src/Editor.svelte#L110 And these can be deleted: https://github.com/TorstenDittmann/omnia-editor/blob/master/src/Editor.svelte#L17-L18

If you want, you can create a PR at omnia-editor :-)