TorstenDittmann / svelte-markdoc-preprocess

Bring the power of Markdoc right into your Svelte applications!
https://svelte-markdoc-preprocess.pages.dev
MIT License
64 stars 4 forks source link

Unexpected default slot in `Fence` component #219

Open maiertech opened 2 months ago

maiertech commented 2 months ago

Describe the bug

I am building my own Fence component, similar to the one from the demo: https://github.com/TorstenDittmann/svelte-markdoc-preprocess/blob/main/apps/demo/src/lib/nodes/Fence.svelte.

According to the Markdoc nodes docs, I expect content, language, and process props in my Svelte component. But I also receive a default slot, which seems to contain the same as content. Since my Fence component does not make use of the default slot, I see a console warning <Fence> received an unexpected slot "default"..

I can silence the warning, but I wonder why I am receiving the default slot.

To Reproduce

I have no public reproduction. But this console warning should be visible with the demoFence component mentioned above. It does not use a slot.

Expected behavior

Just pass content, language, and process?

Screenshots

n/a

Desktop (please complete the following information):

n/a

Smartphone (please complete the following information):

n/a

Additional context

n/a

TorstenDittmann commented 1 month ago

Its probably caused by markdoc itself and potentially be useful for fallbacks or different approaches to add highlighting :-)

for example hljs can do this:

<script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/highlight.min.js"></script>

<script>hljs.highlightAll();</script>
<pre><code class="language-html">...</code></pre>

I will check nontheless 👍🏻

maiertech commented 1 month ago

Yes, might be a gap in the Markdoc docs.