search

TorstenRobitzki / bluetoe

C++ Framework to build Bluetooth LE Server (GATT)
MIT License
142 stars 29 forks source link

Sm #39

Closed TorstenRobitzki closed 5 years ago

TorstenRobitzki commented 5 years ago

First version of a Security Manager.

TorstenRobitzki commented 5 years ago

Not ready to be merged. But I want the CI to run on it.

TorstenRobitzki commented 5 years ago

This pull request introduces 1 alert when merging d98f2f63e312a75c10e40c190378cfee29e611b1 into 9118f1a58610fc07fbdcca0f52169b701ba0ea11 - view on LGTM.com

new alerts:

Comment posted by LGTM.com

xnlcasad commented 5 years ago

Are you planning to merge the whole pack of commits ? Or will you do some squashing/polishing first ?

TorstenRobitzki commented 5 years ago

Well, I would love to just merge the whole PR. What are you suggesting? Otherwise, it will become one giant commit.

xnlcasad commented 5 years ago

Well, I'm not used to having such a verbose history, that goes into details as "remove semi colon", "remove curly braces"

I would do some rebasing to squash "some commits" if at all possible.

But of course it all depends if we can spend some time on that. The biggest priority would be to merge it, so as to have it all in master.

How long would you be willing to hold-off merging? Maybe I can spend some time on a simple rebase. That would give me the opportunity to learn a bit more on what you did.

TorstenRobitzki commented 5 years ago

If you can take the time to polish the history a little bit, then I can hold back the merge until you are done with the polishing.

TorstenRobitzki commented 5 years ago

Current state is, that the examples have to use libnano and the example specific assert() version to fit into flash.