TortugaPower / BookPlayer

Player for your DRM-free audiobooks
GNU General Public License v3.0
1.61k stars 193 forks source link

Improvements re OneDrive #412

Open Resonanz opened 4 years ago

Resonanz commented 4 years ago

First, I love this app. Great work guys !!!

I am using the latest version on iPad and iPhone.

Problem 1. OneDrive performance is really bad. I have a 228 MD zip file that is available OFFLINE in OneDrive and it takes minutes to import after I do an "Add". And I am still waiting, and this is usual behaviour.

Problem 2. The menu when importing from OneDrive is confusing or at least overly complicated. There is a "back" link which is obvious, and a "Select" link which is fine for selecting files to import, however when the zip file is selected there are "Open" and "Done" links. Why do we need both? Either you select the files to import and click "Open" or you go "Back". Done is redundant AFAICT, and detracts from the otherwise nice and simple interface.

Otherwise, loving this project !!!

pichfl commented 4 years ago

The very moment you open the import files dialog you leave BookPlayer. First for the generic file dialog of iOS, then for the file provider of your choice (in your case OneDrive). We have no control over the UI or behavior there.

I can recommend using Zip archives (or even better to convert your books into M4B) to speed up the import process, but since we need to analyze each file, it will never be instantaneous.

GianniCarlo commented 4 years ago

Adding some more technical details to this, we're currently using UIDocumentPickerViewController to provide wide access to other cloud providers without having the burden to individually integrate with each one of them. The problem lies in that it depends on both Apple's design of the component and the third-party app implementation of the File Provider Extension to provide the user experience when importing from them. We currently don't have the man-power to tackle each integration to (at least) the major cloud providers, so we have opted for this compromise, which we have reports that the experience varies between cloud providers

Resonanz commented 4 years ago

@pichfl wrote in #418...

Have you tried going the other way?

Open OneDrive, tap on the … at the end of the file, select "Open in another app" from that menu and select BookPlayer from that dialog.

Wow, yes, that menu option exists. I had not noticed that BookPlayer option in OneDrive. So, testing..... My first attempt at a small zip file imported quickly. Weirdly, OneDrive (which is buggy as hell and poorly designed like most MS software) inconsistently shows the “Open in another app” menu. Of the 30 or so files in that OneDrive folder, the one I wanted failed to show the same full blown menu when I tapped the ellipsis. But yes, in principle the “Open in another app” method works.

So now I’m wondering... can BookPlayer be added to other menus? E.g. ........

One inconsistency is that most app just have the app name in the send to list but BookPlayer has “send to BookPlayer”, so I suggest dropping the unnecessary “send to” if possible.