search

Torvaney / ggsoccer

Plot soccer event data in R/ggplot2
https://torvaney.github.io/ggsoccer/
Other
178 stars 27 forks source link

international pitch dimension size #20

Closed RobWHickman closed 3 years ago

RobWHickman commented 4 years ago

Forgive me if I'm wrong as I'm quite likely to be, but as I understand it, the commonly used default international pitch size is 105x68m and not 100x68m as specified in https://github.com/Torvaney/ggsoccer/blob/c99d76d9060207a5e078839ba9cf1009fbe71a2e/R/dimensions.R#L96

(this would make my life one line of code easier as at the moment I'm basing everything I do on socceraction's definition of the pitch being that size)

I'll stick a pull request in case it's a typo, but obviously ignore if it isn't

(I did notice Marek's tracab function just stretches this which lends some support to it being intentional)

RobWHickman commented 4 years ago

(also the citation in that function doesn't work for me but I'm on holiday inn wifi so it could just be that, I'll also stick a new one in the PR just in case)

Torvaney commented 3 years ago

Yep, I think this is a typo. I've used 105x68 everywhere else, like in the fixed aspect ratio