search

Torvaney / ggsoccer

Plot soccer event data in R/ggplot2
https://torvaney.github.io/ggsoccer/
Other
180 stars 27 forks source link

Allow user to pass in `size` for the lines in `annotate_pitch` #23

Closed lvanden closed 1 year ago

lvanden commented 2 years ago

This would just be a nice-to-have addition. It wouldn't be too difficult and I'm happy to help if needed.

Torvaney commented 2 years ago

This is a good idea and long overdue; I think in general the aesthetics for the pitch elements should be available for the end-user, not just fill and colour. In practice, I think this just means adding support for size, alpha, and linetype.

I'm happy for you to open a PR if you have something in mind, but I should be able to find some time to put something together over the Christmas break.

lvanden commented 2 years ago

Sounds good. I'm happy to review if you'd like another pair of eyes. Thanks for doing this!

Torvaney commented 2 years ago

No problem!

Torvaney commented 1 year ago

Noting for myself to check later: I think using ggforce::geom_arc (or creating an analogous custom geom) for the annotations (as opposed to grobs) would facilitate this.

Would also address #18 and #17