search

Torvaney / ggsoccer

Plot soccer event data in R/ggplot2
https://torvaney.github.io/ggsoccer/
Other
178 stars 27 forks source link

Remove redundant `return`s #5

Closed Torvaney closed 5 years ago

Torvaney commented 6 years ago

Unnecessary and not in keeping with the tidyverse style guide: http://style.tidyverse.org/functions.html#return

More generally, return is a function, which can lead to some unexpected behaviour (hence the recommended style). See 8.3.27 in https://www.burns-stat.com/pages/Tutor/R_inferno.pdf

Torvaney commented 5 years ago

This has more or less been done with a shifting style over time (only direction_label left untouched). Not worth having as a whole issue.