Toryalai1 / MiSTer_ArcadeDatabase

Database for arcade organizer
GNU General Public License v3.0
6 stars 2 forks source link

Horizontal title incorrect #3

Closed mrchrisster closed 1 year ago

mrchrisster commented 1 year ago

I noticed /media/fat/_Arcade/_Organized/_4 Video & Inputs/_2 Rotation/_Horizontal/Air Duel (Japan, M72 hardware).mra is not a horizontal game

Toryalai1 commented 1 year ago

Hi Thanks for the heads up. I'll fix it in the next release

Toryalai1 commented 1 year ago

This is now done.

mrchrisster commented 1 year ago

Hey hey, just putting this here since it's related to the same issue. I noticed Galaxian is playing with my horizontal games: /media/fat/_Arcade/_Organized/_4 Video & Inputs/_3 Move Inputs/_2-way horizontal/Galaxian (Namco, Set 1).mra

/media/fat/_Arcade/_Organized/_4 Video & Inputs/_2 Rotation/_Horizontal/Air Duel (Japan, M72 hardware).mra is also still in my list ... maybe an issue on my side? Used update_all recently.. I'll do a reset on Arcade Organizer and report back

UPDATE Can confirm Air Duel has disappeared but Galaxian is still in the horizontal folder

Toryalai1 commented 1 year ago

Thanks for the report. I'll fix it

mrchrisster commented 1 year ago

And one more if you don' mind: /media/fat/_Arcade/_Organized/_3 Collections/_4 By Genre/_Shooter - Horizontal/Scooter Shooter (W).mra

Toryalai1 commented 1 year ago

Hi, I just checked Galaxian and it is correct as it is. It is a 2-way horizontal input game. You can only move the ship horizontally.

Scooter shooter should also be correct. While it is a vertical-oriented game, you move horizontally.

I'm going to rework the genre section of the database so that it is according to MAME standards.

mrchrisster commented 1 year ago

Ah ok I see, that's too bad. For Super Attract Mode I filter horizontal games with a simple grep for horizontal. This means I would need to find another way to create a horizontal list. Thanks for letting me know!

Toryalai1 commented 1 year ago

Hi, I did a major overhaul of the category. It should now 100% follow MAME. Have a look :)

Also, why not separate by the rotation tag instead? You will either have horizontal, vertical (ccw) or vertical (cw)

mrchrisster commented 1 year ago

Yeah, that's what I should do and have done in the past. I somehow thought casting a wider net might be a good idea and the folder structure changed at some point which screwed with my script... but yeah, should be an easy fix. Thanks for all your work!

mrchrisster commented 1 year ago

Hey hey, just noticed: /media/fat/_Arcade/_Organized/_4 Video & Inputs/_2 Rotation/_Horizontal/Exerion (Taito).mra is not a horizontal game. I have Super Attract Mode running and every now and then notice things like that, hope you don't mind ;)

Toryalai1 commented 1 year ago

Thanks for the info. I will update it this Friday with other fixes :)

Toryalai1 commented 1 year ago

Just pushed an update. It should be vertical (cw) now: image