Tosche / Glyphs-Scripts

Tosche's Python scripts for glyphs
Apache License 2.0
77 stars 24 forks source link

"Copy Kerning Pairs" broke on Glyphs 3? #21

Open synthview opened 3 years ago

synthview commented 3 years ago

Hello!

"Copy Kerning Pairs" script does not seem to work with Glyhps3

Copy Kerning Pairs Error: 'NSKVONotifying_GSFont' object has no attribute 'kerningDict'

;(

Tosche commented 3 years ago

Rafał just fixed it and I pulled the request. It should be fine now.

synthview commented 3 years ago

unfortunately not :(

synthview commented 3 years ago

I get this error

Copy Kerning Pairs Error: { @MMK_R_horizontallineextension = 0; @MMK_R_horizontallineextensionCASE = 0; }

Could you please help? I really need this script to run to be able continuing my work ;(

Tosche commented 3 years ago

Schriftgestalt made an update two days ago. Does it work better for you now?

synthview commented 3 years ago

I have no more the "kerningDict" error, but unfortunately the script does nothing (does not copy the kern pairs). And I see the error pasted yesterday

Copy Kerning Pairs Error: {
@MMK_R_horizontallineextension = 0;
@MMK_R_horizontallineextensionCASE = 0;
}

;(

Tosche commented 3 years ago

And when do you see that? (i.e. how can I reproduce the effect?) I haven't tested it in Glyphs 3 but it may be file-specific.

synthview commented 3 years ago

I've just tried with another old font file (a totally other font) and I get the same kind of error `Copy Kerning Pairs Error: { @MMK_R_A = 10; @MMK_R_O = -10; @MMK_R_T = -50; @MMK_R_V = -50; @MMK_R_Y = -55; @MMK_R_a = 10; @MMK_R_dash = -30; @MMK_R_four = -20; @MMK_R_guillemot = -40; @MMK_R_nine = -30; @MMK_R_numbersign = 20; @MMK_R_quote = -50; @MMK_R_t = -30; @MMK_R_u = -10; @MMK_R_v = -35; @MMK_R_y = -45; 6275D8C3-0363-4F98-A703-C1278AB24411 = -20; 6BD88B87-AF56-4454-A101-91E1AD7CD683 = -40; F5D7DF28-7A55-48F3-A80A-3A5EC5D2784C = -70; }

` My test case: I take the glyph / (slash), set both left and right kerning groups called 'slash'. Then I try to copy values from @A for the left @slash and from @V to right @slash.
Screenshot 2020-12-11 at 21 46 58

Tosche commented 3 years ago

I'm sorry, I tested a similar case but couldn't recreate the issue. I need your Glyphs file.

synthview commented 3 years ago

ok, where can I send you (privately)?

Tosche commented 3 years ago

tosche@mac.com

synthview commented 3 years ago

sent

kosbarts commented 7 months ago

Hey Tosche,

I am running this on G3 3.12 (3151) and it runs once and then the next time I try to run it Glyphs crashes.

Have you observed any such behaviour?

Tosche commented 7 months ago

Hi Kostas, sorry to be late. I want to narrow down the cause; which button caused Glyphs to crash?

kosbarts commented 7 months ago

I just run a Pair copy for All Masters. Press Run and works fine the first time. Then if I try to copy another Pair Glyphs crashes the moment I press Run. It happens with All Masters active and inactive. It also happens if I close the window and re-open it before trying again. I tried it with 2 different files and it happens exactly the same way.

Macro report is empty after restart so I don't know if it produces some report or not when the script runs.

Tosche commented 7 months ago

I am trying it, but it doesn't crash on me no matter what I do. Shall we do a call?

kosbarts commented 7 months ago

Hi Tosche,

I just got a new M3 Pro and the script is working fine for pair to pair kerning. I haven't tested it on the old mac yet. The presets are problematic though and Case to Small Caps is not working at all.

I made some alterations to the script and I have a working version but there is one small hiccup that I would be really happy to discuss with you on a call if you have some time before putting the updated script on my repo.

kosbarts commented 7 months ago

@Tosche I did my best and I have a version that fixes all the issues I had. I put it on my fork and created a pull request for you to review if you want.