search

TosiDrop / vm-frontend

Frontend for TosiDrop
MIT License
6 stars 6 forks source link

ADA rewards need special handling #118

Open wolf31o2 opened 2 years ago

wolf31o2 commented 2 years ago

ADA isn't a token on the chain, but the coin. If the user has an ADA reward greater than the withdrawal + selected tokens, we should be able to withdraw without a send. Also, the calculated amount doesn't appear to be correct for this case. I had 1 token + 3.6 ADA as rewards.

reqlez commented 1 year ago

@aryelciu001

Just have to have some logic, if user selected ada token, and if token is more than deposit amount required, have a button that says withdraw using ADA rewards instead. Withdrawing using ADA rewards should just be an API call.

However, what i do not like, is the ability of somebody to abuse it and waste people's transaction fees from their ada balance. Maybe should be required to have connected wallet and "Authenticate" the user by making them sign a transaction with their wallet, but not a Cardano transaction but just singing with their private key to authenticate it is indeed them doing this.

There, i finally found a use case for the wallet authentication @wolf31o2 ;-) Yes i realize that users can just go to VM and do this already without authentication, but i'm saying maybe this should not be allowed at VM side either? Not sure. Just throwing some ideas around.

aryelciu001 commented 1 year ago

sounds like too much work for little to no benefit

wolf31o2 commented 1 year ago

This is how VM works. TosiDrop is not correctly representing how the backend works to users. This is the oldest bug in TosiDrop.

reqlez commented 1 year ago

The Original Bug. Soon to be 1 years old lol