Fixed wrong variable names

Solanya commented 5 years ago

How does this keep happening Variable name was wrong in the local music effect, renamed it in the regular music effect for good measures.

Meorawr commented 5 years ago

Something something luacheck on this repo might be a good idea.

pandarenqintang commented 4 years ago

给作者们：谢谢你们制作了这么棒的插件。经过一年半的使用，已经有数百中国RP玩家使用你们的trp3玩。

走在暴风城经常可以收到附近RP玩家的道具和即兴角色扮演。这个汉化版由金色平原的秦唐和格雷森丶黑爪共同完成。但我们不知道怎么更新，只能通过邮件发送给你。

在制作自定义物品的时候我们还碰到几个问题： 1、作品没有中国旗帜 2、国外维基无法登陆，我们想知道更多参数，像${trp:target:full}这样的 3、在过场动画里能否指定其他RP玩家模型

Dear GREAT Authors,

Thank you for making such a great plug-in! After one and a half years of use, hundreds of Chinese RP players have used your trp3 to play. Walking in Stormwind City often receives props and improvised role playing from nearby RP players.

This Chinese version was completed by 金色平原-秦唐 [me:)] and 金色平原-格雷森丶黑爪.But we don't know how to update it. We can only send it to you by email.

download url 1: http://img.nga.178.com/attachments/mon_201907/23/5kQ5-gm7sXmZ61.rar?filename=TRP3%201.6.2%20+%20TRP3%20Extended%201.3.2%CD%EA%D5%FB%BA%BA%BB%AF%B0%E6by%B8%F1%C0%D7%C9%AD%D8%BC%BA%DA%D7%A6.rar

or download url 2: link: https://pan.baidu.com/s/1YtEfy7Mct7Ke2eRwu_fS2g Extraction Code: z7p7

We also have several problems in making custom items:

There is no Chinese flag in the works.
Wikipedia abroad can't log in. We want to know more parameters, such as ${trp: target: full}.

Can other RP player models be specified in the in-theater animation?

                                                                                                          Respectfully,

Solanya commented 4 years ago

Hi, would have been better to open a new ticket in the Issues tab than adding comments in an unrelated pull request ^^

I'm confused as to what you're asking for regarding updates, we use Curseforge to handle localisation and you did the Chinese localisation on it : https://www.curseforge.com/wow/addons/total-rp-3-extended/localization/languages/99/phrases#234850 Players just need to download the latest version there (https://www.curseforge.com/wow/addons/total-rp-3-extended) and set the addon locale to Chinese in Advanced Settings if it isn't. Or is there issues to access the website itself ?

As for the other points :

I can look into adding a Chinese flag.
The Github wiki isn't on Wikipedia : https://github.com/Total-RP/Total-RP-3-Extended/wiki (in particular, https://github.com/Total-RP/Total-RP-3-Extended/wiki/Variable-tags for the other possible tags)
You can't use other players' model except by using player (for the player model) or target (for your target's model), you can't use specific players by name, technical limitation from the game.

If there's any more questions, it would be easier to discuss them on Discord (if possible for you) : http://discord.totalrp.com

Total-RP / Total-RP-3-Extended

Fixed wrong variable names #150