search

Total-RP / Total-RP-3

The best roleplaying add-on for World of Warcraft.
http://curse.totalrp.com
Apache License 2.0
35 stars 19 forks source link

Convert preset additional info & traits to custom #1003

Closed Raenore closed 1 month ago

Raenore commented 1 month ago

https://github.com/user-attachments/assets/0225bd9a-5d8c-4355-9df3-f1dcd2b6c42a

Basically allows you to convert a preset additional info or trait to be custom. On conversion, it will keep its icon, values, names, etc. It just becomes customizeable. image

[!NOTE]
The action button SetScript had to be moved out of the if frame == nil then block as it would otherwise not know its IDs got changed, which in turn would make it never know to stop hiding "convert to custom" from the user.

If an additional info was one that added something to the tooltip, the user gets a warning that mentions it will be gone after conversion. For the above behavior to work, a shownOnTooltip boolean field was added to all MiscInfoTypeData. image

[!IMPORTANT] Two new localizations have been added:

  • REG_PLAYER_CONVERT
  • REG_PLAYER_CONVERT_WARNING
Raenore commented 1 month ago

For the (lesser) Ancients, I have added icons and tooltips explaining which additional infos show on the tooltip.

2024-07-14_14-01-46-216

(Video was without icons, but it shows the tooltip.)

https://github.com/user-attachments/assets/d87731af-7e2a-4abb-ae52-c34fdc4d6a94