search

Total-RP / Total-RP-3

The best roleplaying add-on for World of Warcraft.
http://curse.totalrp.com
Apache License 2.0
36 stars 18 forks source link

Remove special handling of empty custom class on MSP #1088

Closed Solanya closed 4 months ago

Solanya commented 4 months ago

Once upon a time, special handling was added for the custom class field coming from MSP, presumably so that it wouldn't use the game fallback and instead just show no class, as this was how MRP displayed it.

The Kat Archives mention that the custom class field was only added to MRP in BfA. Presumably, the behaviour was unintended and MRP was fixed to use the game class as a fallback, but we never got the memo. As such, this has been broken forever and we wouldn't show a class if the field was left empty.

I've removed the special handling so that we use the game class as a fallback once again.

Solanya commented 4 months ago

Before it would put " " as the class so that it wouldn't be an empty string, therefore not using game class as fallback and appear with no class. Now, we leave the class string empty, so it uses the game class as fallback once again.

Meorawr commented 4 months ago

Ah, right.