search

Total-RP / Total-RP-3

The best roleplaying add-on for World of Warcraft.
http://curse.totalrp.com
Apache License 2.0
35 stars 19 forks source link

Fix pin button passthrough for 11.0.2 #1119

Closed Meorawr closed 1 month ago

Meorawr commented 1 month ago

Blizzard changed the logic for map pins such that they attempt to configure button passthrough after the OnAcquire method is called on the pin.

This causes issues with our player map scan as we only respond to right-clicks for that pin, and disable the passthrough in its OnAcquire handler. Blizzard then goes and resets the passthrough to include right-clicks again, thus eliminating our change entirely.

To resolve this we can just nop out the CheckMouseButtonPassthrough method which is called by Blizzard to apply the passthrough change on their end.

DJScias commented 1 month ago

Review was unintentional, I was looking at the code (As I had this issue myself) and clicked that by accident.

Please disregard.

Solanya commented 1 month ago

Review was unintentional, I was looking at the code (As I had this issue myself) and clicked that by accident.

Please disregard.

You're now legally liable for any issue that happens following this fix.