Total-RP / Total-RP-3

The best roleplaying add-on for World of Warcraft.
http://curse.totalrp.com
Apache License 2.0
35 stars 19 forks source link

Fix tooltips for party units on other maps #1130

Closed Meorawr closed 1 month ago

Meorawr commented 1 month ago

The tooltip logic when the mouseover unit changes explicitly consults the "mouseover" unit or falls back to the world cursor support in mainline when enabled.

For units on different maps to the current player, the client never associates the "mouseover" unit to them - it'll instead display the tooltip with their party/raid unit token which we've never checked.

The current tooltip unit logic has been adjusted to consult the default GTT if shown and use its unit if set, before then falling back to the "mouseover" token and world cursor support.

Note: This may in fact break things. Extensive testing required because this logic is garbage.

Raenore commented 1 month ago

I have been testing this for the past two nights during radiant echoes and moving about maps. So far it's worked.

Not green checking it just yet as I'm sure I can find more extensive test cases still, but figured I'd report that in already.