Total-RP / Total-RP-3

The best roleplaying add-on for World of Warcraft.
http://curse.totalrp.com
Apache License 2.0
34 stars 19 forks source link

Handling of default profile in customizations and directory #894

Closed Solanya closed 1 month ago

Solanya commented 1 month ago

The way the default profile works leads to weird displays when it comes to customization. To be able to quickly identify whether a profile ID belongs to a regular profile or the default one, the last character is now a special one (I chose an asterisk but I'm not picky, we can pick something else).

(Old default profile IDs get replaced by the flyway, and the old links will automatically reselect the new profile ID when the old one can't be found)

This way, I can remove customization from chat and nameplates, and hide profiles from the directory if they're default. There might be other places where this should be done, I'll look around, but wanted to get the first draft out in case there's major things to do better.

(Oh yeah, also fixed a bug where the fallback function for GetColoredName was called with the wrong arguments when the unitID or realm were missing, leading to chat messages having incorrect displays)