search

Total-RP / Total-RP-3

The best roleplaying add-on for World of Warcraft.
http://curse.totalrp.com
Apache License 2.0
34 stars 19 forks source link

Add companion custom name and color to Tooltips #905

Closed Raenore closed 1 month ago

Raenore commented 1 month ago

This adds support for tooltips to show companions their custom names and colors.

Take a companion like this: Wow_GROaAraMLl

Before this change, tooltip with someone targetting that companion had this: Wow_DPUkRN9svD Basically OOC name always and the WARRIOR color.

After this change, it now properly gets the RP name and color set: Wow_vA8Fo1kdrO Look how pretty.

Don't decimate me too hard, Meow.

Meorawr commented 1 month ago

Let the games begin.

Raenore commented 1 month ago

If I were a butthole I'd ask you to reduce the scope of targetTarget but I think you've survived this first hazing - both in this PR and in-game.

You did a job, Buzzy. I'm neutral on the matter.

I'll do you one better, I also moved targetEnglishClass to the proper scope. That's two whole lines for the price of one.