Total-RP / Total-RP-3

The best roleplaying add-on for World of Warcraft.
http://curse.totalrp.com
Apache License 2.0
36 stars 18 forks source link

The Great Tooltip Purge (the purge giveth and taketh) #995

Closed Raenore closed 3 months ago

Raenore commented 3 months ago

An effort to make all (read: the most common) our tooltips go through a consistent format, sprinkled with some fixes and localization checks. This is an on-going effort and stuff probably might still change and/or gets missed still.

[!NOTE] Extended might follow soon(TM), I've got a few more things to tackle that isn't specifically a "purge" for that beast (like porting the dropdown changes to Extended).

The format works as follows:

- Titles are always white.
- Descriptions are default gold.
- Highlights and/or keywords in Descriptions are green.
- Actions (clicks, what the tooltip's element DOES) are in green.

[!TIP] The following best practices were observed (which you can deviate from at any point of time, if you'd like):

  • If a tooltip has both a Description and Actions, the Actions are separated by a whiteline to stand on their own. If there is no Description, there is no whiteline.
  • If a button is self-explanatory (Save, Cancel, Remove), it will not have a tooltip unless its action cannot be inferred from the button itself (for example, an additional right-click menu).
  • A tooltip will open from the top-right edge ("ANCHOR_RIGHT") on the element it is attached to, however there are some exceptions:
    • The Toolbar and Targetframe tooltips will open right above the elements ("ANCHOR_TOP").
    • Certain popups where the tooltip would obstruct too much (glance editor), anchor to the left ("ANCHOR_LEFT").
    • Browsers (icon browser, companion browser) do not have an y 5, they are tied directly to the element they belong to.

[!IMPORTANT] This is not a strict set of rules! Features will come in that may not adhere to these practices at first (or ever), because sometimes things can't or won't fit into a consistent idea. Anyone is free to open a PR to resolve any inconsistencies, which can then be reviewed on a case-by-case basis.

Changelog

This is just what I remember, it's possible I might've missed a thing or two (or three..).

New

General

Glances

Profile - About

Relations

Changes

General

Companion Browser

Profile - About

Profile - Characteristics

Profile - Notes

Target Frame

Toolbar Frame

Fixes

Directory

Profile - About

Profile - Characteristics

Profile - Misc

Relations

Removals

General

Dashboard

Profile - Characteristics

Raenore commented 3 months ago

Finally through it all.

Thank you for that, I went through all the things to see if you missed something while you checked for things I missed. All looks fine so far, but I'm sure there's still stuff hidden that Meow or even more re-reads will find out.