TotalCross / totalcross

TotalCross is a Software Development Kit that helps cross platform application development. Currently supported platforms are: Windows, Wince, Android, iOS, Linux and Linux ARM for embedded systems.
https://www.totalcross.com
GNU Lesser General Public License v2.1
222 stars 40 forks source link

Contributors don't know the exact contribution guidelines #237

Open teras opened 3 years ago

teras commented 3 years ago

Describe the bug

A clear and concise description of what a contributor should put as a commit message. Although there's an error message that describes it, even if following its guidelines, it's not enough.

For example #232

To Reproduce

Create a new pull request and follow the vague error guidelines.

Expected behavior

A CONTRIBUTION.md file should be updated with the minimum requirements on how to contribute to TC. Now it's too complicated,

acmlira commented 3 years ago

We already have some clear guidelines in my opinion:

https://github.com/TotalCross/totalcross/blob/master/CONTRIBUTING.md#commiting

I see some problems like the wrong commit example and the types of commit require a more macroscopic and complex view (what we could make clearer by giving some options or setting a list of possible types).

teras commented 3 years ago

In my opinion as an outsider, it is not

I know I am nitpicking, but if I and @VicMisael have issues, I am 100% certain that many many others might have ( remember #170 issues)

acmlira commented 3 years ago

That's it! I agree with many of them and here is my suggestion for changes:

acmlira commented 3 years ago

Hello you all, I also think that we need a list of commit types. My suggestion:

They are simple and relatively broad categories, but you can explain better your changes in body section 😄

Keep it simple

teras commented 3 years ago

I like these categories, there might be more things missing, but for now let's not bloat it. Start with these and see if we add more and/or deprecate some others.

I'd also suggest the following emojis which will replace the textual with the image:

doc → 📝 api → ☕ lib → ⚙️ cicd → 👷 build → 🛠️ fix → 🐛

nmarquesin commented 3 years ago

If the commit is related to a new feature, for instance, a new TC component, should it go under api ☕?