search

TotalFreedom / TotalFreedomMod

A server modification for the TotalFreedom server
http://totalfreedom.me/
Other
45 stars 222 forks source link

Limit fireworks #899

Open JeromSar opened 9 years ago

JeromSar commented 9 years ago

Mass amounts of fireworks can lag clients. Rate limiting fireworks may be a good idea.

ChargedCreeper commented 9 years ago

I agree. I've experienced crashes from people rapidly spamming fireworks in the past.

Hockeyfan360 commented 8 years ago

Keep in mind that you would have to find a way to prevent dispensers from shooting fireworks at rapid rates.

Wild1145 commented 8 years ago

@Hockeyfan360 Or we just disable dispensers being able to shoot them full stop?

Hockeyfan360 commented 8 years ago

@Wild1145 That'd be a big breach of freedom.

I think that admins should be alerted that someone is spamming them rapidly. If they have bad intentions, they can be banned. If they are putting on a firework show or similar, they shouldn't be punished/prevented.

Wild1145 commented 8 years ago

@Hockeyfan360 And in the time it takes for an admin (If there is one online and not pissing around) to actually respond to the issue the server could already be crashing. While I do not wish to remove the freedom from the players, a line has to be drawn somewhere. Limiting the amount of entities that a dispenser can launch will likely prove to be difficult at best. I personally can see no practical way of implementing this without putting global entity limits in place, and this would still not solve the root cause.

JeromSar commented 8 years ago

How about limiting the amount of firework entities that may exist in a given chunk. Any new spawned firework entities could be blocked and removed.

Hockeyfan360 commented 8 years ago

@JeromSar I think that that would be good.