Trolldemorted
commented
6 years ago From doing some testing in RPFM with the patch to use the lib, I found some problems while saving. When hitting save, and then reopening the PackFile, the resulting PackFile somehow loses his last PackedFile, and the rest are unopenable.
Nice catch! I forgot that pfh5 index entries without the big header bit set (aka every warhammer2 pack, I assume) have an extra 0 in the index when calculating the index size, thus the index size was incorrect, so the last item didn't fit in it. Fixed it in 0.1.16, can you test if the problem persists?
Why is creating an empty PackFile blocked?
I assumed creating empty packs doesn't make sense since they don't contain anything, but if you'd like to allow that I can of course create an empty index.
If I understand it correctly, when saving, for each PackedFile, the lib reads the data from the source PackFile, then write it in the destination PackFile. How is that supposed to work if you are just updating a PackFile's data (a normal "Save")? For what I see, it tries to read data from a file that has been partially modified, which can be the cause of some of the corruption problems from above.
The caller has to ensure all packed files are memory-backed if the source file is to be overwritten. My rpfm pr enforces this by first ensuring all packed files are memory-backed before truncating the file with File::create:
pub fn save(&mut self, pack_file_path: &PathBuf) -> Result<()> {
// ensure every packed file has the correct timestamp and path and is loaded into memory before we (potentially) overwrite the file
let mut packed_files = Vec::with_capacity(self.packed_files.len());
for packed_file_view in &mut self.packed_files {
packed_file_view.packed_file.get_data()?;
packed_file_view.packed_file.timestamp = Some(self.timestamp);
packed_file_view.packed_file.path = packed_file_view.path.join("\\");
packed_files.push(&packed_file_view.packed_file)
}
// We try to create the file
let mut file = File::create(pack_file_path)?;
tw_pack_lib::build_pack_from_memory(&packed_files, &mut file, self.pfh_version, self.bitmask, self.pfh_file_type, self.timestamp).map_err(From::from)
}
Frodo45127
From doing some testing in RPFM with the patch to use the lib, I found some problems while saving. When hitting save, and then reopening the PackFile, the resulting PackFile somehow loses his last PackedFile, and the rest are unopenable. Checking it with a Hex Editor shows that:
After checking the "save" functions, I also have some questions: