search

TotallyInformation / node-red-contrib-fs

Node-Red node template for host filing system handling
Apache License 2.0
14 stars 6 forks source link

V1.4.1 lost the ability to pass in the 'start' option from v1.3.2 #22

Open juggledad opened 3 years ago

juggledad commented 3 years ago

Before logging an issue, please make sure that you are using latest version on npm. If you are testing a development version (@next on npm or the version on GitHub), please make sure that you let me know as well.

Please ensure that as much of the following information is included as possible:

Software and Package Versions

Software Version
Node.JS v12.13.0 and v12.19.0
npm v6.14.8
Node-RED v1.1.3
fs node v1.4.1
OS macOS and Rpi Stretch v9
Browser Safari

How is Node-RED installed?

via recommended method from the documentation

What is the issue

V1.4.1 lost the ability to pass in the 'start' option from v1.3.2. If you blank out the 'Start Folder' option, you get a red triangle on the node and at deploy, a popup with:

The workspace contains some nodes that are not properly configured:

[Flow 4] File Lister (fs-file-lister)
Are you sure you want to deploy?

CancelConfirm deploy
travis-icorein commented 2 years ago

I initially tried downgrading to v1.3.2 and couldn't get it to run either, until I realized it wasn't msg.start that needed set, but msg.payload.start. Correcting that, and both versions work fine for me (in nodered/node-red:2.0.4-14-minimal)

However, poster is correct that you can't omit the values from the UI. Node appears to ignore what it set via UI when params are passed in (via msg.payload). Leaving default / allows editing/deploying/running without issue.