search

TotallyInformation / node-red-contrib-fs

Node-Red node template for host filing system handling
Apache License 2.0
15 stars 6 forks source link

Added option to include hidden files is listings #6

Closed juggledad closed 5 years ago

juggledad commented 6 years ago

Added an option (Include hidden files in output?) which, went set, will ignore files who's name starts with a period(.)

TotallyInformation commented 6 years ago

Hi @juggledad , many thanks for contributing.

Just a quick check. Have you tested this on a Windows PC? This module should be cross-platform.

juggledad commented 6 years ago

I thought I responded several hours ago but don'tsee it...

No I can't test it on Windows since I only have access to my Mac and Pi.

TotallyInformation commented 6 years ago

I'll see if I can get some time to test it.

juggledad commented 5 years ago

Julian...did you ever get time to check this out?

TotallyInformation commented 5 years ago

Hi, apologies this has taken so long.

While I am not going to merge this PR, I have used the code. There were a few tweaks that I wanted to make. For example, the default setting is true rather than false since the previous version defaults to including them. Changing the default would mean creating a new major version.

So I am closing this but rest assured that the feature will appear in v1.1.0 which is about to be published. Many thanks for your input and I've added you to the contributors.