search

TotallyNotChase / glitch-this

:camera: Glitchify images and GIF - with highly customizable options!
MIT License
1.76k stars 63 forks source link

Refactor #36

Closed DavidRomanovizc closed 3 years ago

TotallyNotChase commented 3 years ago

What exactly is improved by this PR?

DavidRomanovizc commented 3 years ago

What exactly is improved by this PR?

code readability. According to the PEP8 style documentation

TotallyNotChase commented 3 years ago

The rest of the codebase follows an intuitionistic formatting style, not strictly pep8. Consistency should be important. Therefore, I think formatting only one part of the codebase is a bad idea.

I also don't intend to stick to pep8 strictly. Here's a yapf config of the formatting style I generally use-

[yapf]
based_on_style = pep8
spaces_before_comment = 4
indent_width = 4
dedent_closing_brackets = True
join_multiple_lines = True
each_dict_entry_on_separate_line = False
indent_dictionary_value = False
allow_multiline_dictionary_keys = False
coalesce_brackets = True
column_limit = 120

I don't really have any plans of making a re-release just for formatting changes. But you may feel free to commit that config file on the repo and run yapf on all source files. You can make a separate PR if you'd like to take that on.