TotallyNotChase / glitch-this

:camera: Glitchify images and GIF - with highly customizable options!
MIT License
1.75k stars 63 forks source link

Project full refactoring: Stage 1 #42

Closed ShahriyarR closed 2 years ago

ShahriyarR commented 2 years ago

Dear author, First of all thanks for this beautiful idea and the project.

TotallyNotChase commented 2 years ago

Hello, This looks quite neat! Though I don't currently have the time to do a thorough review and merge, I appreciate you taking the time and effort to demonstrate a nice refactoring!

I think glitch-this, as it currently stands, is more or less in an "archived" state and will continue to stay that way unless any pressing bugs are discovered, which I'll definitely try fixing. But other than that, I'd like it to stay the way it is. Not because the code is "good" (it certainly isn't haha!) but because my personal interests and time allocations have diverted away from python in general.

Please do feel free to have an improved version as your fork though, and maybe even write up a guide on open source refactoring so others could learn a thing or two from you. You can send a link to such a guide my way and I'll be sure to read it over a weekend or two!

ShahriyarR commented 2 years ago

Hello, thanks for the clarification :) Indeed the project is a very interesting one in terms of showing and teaching something, especially when you glitch your worst picture and it gets shiny :D I got your point and will continue my work and not will not open a new PRs as we have concluded)