TotemArts / Rx_Launcher

Renegade X Launcher
12 stars 9 forks source link

Disk space check / download precentage correction / shutdown process / Players tab & more #44

Closed Tostifrosti closed 3 years ago

Tostifrosti commented 5 years ago

In the last months I've been (slowly) updating the Launcher to fix those nagging issues. This PR is a draft because I want to push more fixes in the future. There are a lot of changes, so this way you guys can already look into the recent commits and comment if you see any mistakes.

Changes:

New:

Removed:

Known issues:

This PR is related to an previous pushed PR that hasn’t been merged because of inactivity from my end. I will try to answer/clarify the questions/statements in that PR:

  1. JAJames:

    Validation component exceeding 100% when installing a patch

  1. JAJames:

    It also seems that anytime I launch the launcher, it prompts to update to the latest version (even if it already is)

  1. JAJames:

    There seems to be a 100% reproducible crash (no error displayed) when you completely lose internet connectivity while attempting to patch/install the game. This is the most significant of the above issues. However, it's not entirely clear if this is caused by these changes, or if it's an existing issue. The crash seems to be caused by us throwing an exception, but never catching it to display to the user.

  1. JAJames:

    If a mirror is unable to deliver files (i.e: setup a proxy, and start refusing connections mid-install for a specific mirror), the launcher will continue attempting to use that mirror indefinitely. We need to change this behavior such that any mirror which fails the retry strategy is removed from the valid mirror list, so that it's not used for future downloads by the client.

Of course this PR doesn't fix all the issues, but I'll try my best to work on those issues. Hopefully you guys will find some time to look the changes ;) Feel free to comment on any changes below!

SonnyX commented 5 years ago

The PR looks amazing, this might make it to the public. I do however advice not to spend any further time on this launcher since we are currently working on a new one that is progressing rapidly and addresses many of the issues and feature requests this launcher has. If you are into helping on the new launcher, please send me a message on Discord.

JAJames commented 5 years ago

I'm slamming this through

JAJames commented 5 years ago

Except there's a merge conflict

Tostifrosti commented 5 years ago

@JAJames Merge conflicts resolved ;P

SonnyX commented 3 years ago

Closed due to inactivity & deprecation of the current launcher in favor of https://github.com/TotemArts/Launcher/