Totenfluch / EventItemsSpawner

Plugin for Sourcemod to spawn items for holiday events
12 stars 5 forks source link

Sourcemod 1.10 is stable. Need to update the Eventitem Spawner (if you got time) #1

Closed Sacricx closed 2 years ago

Sacricx commented 4 years ago

Since SM 1.10 is stable and in use on my servers, this plugin sadly won't work anymore. It would be pretty kind, if you gonna update this plugin since SM 1.10 is stable because you did a really really good job here and I'd love to continue using this awesome plugin on my servers. Currently works (but can't compile) with SM 1.9

This may help for a possible update/fix: When I try to compile the plugin with Sourcemod 1.9 or 1.10 then I get the following error: EventItemsSpawner.sp( 8 ): fatal error 183: cannot read from file: "autoexecconfig".

best regards

Sacricx

Totenfluch commented 4 years ago

autoexecconfig.txt

Sacricx commented 4 years ago

Thank you very much for providing the autoexecconfig.txt ! Since I can only guess where to put this in, I tried all diffrent folders in addons/sourcemod/scripting/ also in addons/sourcemod/. But no matter where I put the autoexecconfig.txt the error shows up on compile. I would appreciate very much, if you could tell me/people who want to know, where to put this cfg. That would be cool :) !

best regards

Sacricx

Totenfluch commented 4 years ago

rename it to autoexecconfig.inc

and it's /scripting/includes

Sacricx commented 4 years ago

Although this issue is closed already I want to share my solution of how to compile with Sourcemod 1.10 since adding the autoexecconfig.inc was just the first step which was neccessary to be able compile the plugin.

  1. You need to add smlib but download the traditional syntax branch since the master branch uses deprecated syntax and won't let you compile against SM 1.10.

  2. Adding smlib: Open your smlib-transitional_syntax.zip. Go inside the smlib-transitional_syntax folder and drag and drop the scripting folder to your servers addons/sourcemod/scripting folder

DOWNLOAD HERE: https://github.com/bcserv/smlib/tree/transitional_syntax

  1. Make sure to add: emitsoundany.inc, map_workshop_functions.inc, multicolors.inc, colors.inc, morecolors.inc store.inc to your include folder.

DOWNLOAD HERE:

  1. Edit store.inc

REMOVE THE COMPLETE LINES:

The plugin should compile successfully with 6 warnings which you can ignore for now. I hope this detailed solution and report helps someone who wants to compile against SM 1.10.

  1. To Totenfluch:

This warnings are related but can be ignored until SM 1.11 I guess:

Totenfluch commented 4 years ago

You are basically describing how to compile the plugin. This does not seem to be an issue with 1.10 in particular just you having to go through the though process of compiling this. I could have done a better job documenting this bu that's why there's a .smx in the directory.

about the 1.11 yes I agree this is problematic but since the whole plugin relies on enum-structs this will be a though one to migrate

Totenfluch commented 4 years ago

https://github.com/Totenfluch/EventItemsSpawner/commit/b8eccbfa0df0a2d0005e0c411620124ef97b0342

Sacricx commented 4 years ago

You are right its no issue with SM 1.10. Without the include files you can't compile it against SM 1.9 either. That was not necessary for me in the past tho since the provided .smx in the directory worked well for me with SM 1.9. Because of that I did never try to recompile with SM 1.9 and thought it's been an issue with SM 1.10.

Unfortunatley the provided .smx doesn't work with SM 1.10 even when the cfg's are set properly (no errorlogs tho). That's why I wanted to recompile the .sp file. Once I looked at the errors, I got rid of them step by step. And yes I could have made this alot easier by requesting you to add all the necessary include files but to edit the store.inc before.

The whole reason for my issue was simply that some plugins I'm using require SM 1.10 meanwhile which forced me to update to SM 1.10. But your plugin is so nice that I didn't want to miss it on my servers <3

Yeah and since I had no guarantee, that you come back to this issue at anytime in the future I wanted to make sure to let people know about my "solution" to this and described for them how to be able to compile against SM 1.10.

I do appreciate your reply very much and want to say that its still nowadays an awesome plugin for my Community. It was a really great idea from you to invent it and we don't want to miss it on our servers.

So long story short, thank you very much for adding the required include files to the master branch.

I wish you a good time mate :) !

Sacricx