`OPTIONS` request should not return `BadHandshakeMethod` error

Totodore / socketioxide

A socket.io server implementation in Rust that integrates with the Tower ecosystem and the Tokio stack.

https://docs.rs/socketioxide

MIT License

1.13k stars 49 forks source link

`OPTIONS` request should not return `BadHandshakeMethod` error #286

Closed Totodore closed 3 months ago

Totodore commented 3 months ago

Describe the bug Some clients send an OPTIONS request before connecting with a GET request. In these cases, the engine.io lib should send a 200 OK and not a 400 bad request to the OPTIONS req.

To Reproduce Run the basic example server and try to connect with https://hoppscotch.io/realtime/socketio

Expected behavior Connection should work.

Totodore commented 3 months ago

Erratum, it should be handled by the CORS layer before or by axum.