search

TouK / excel-export

excel-export grails plugin
58 stars 32 forks source link

Adds multiple sheet support w/o breaking current API or DSL, supporting the DSL on subsequent sheets #15

Closed joeRinehart closed 10 years ago

joeRinehart commented 10 years ago

Hey man,

I work with Brian Kotek and another developer, both of whom have needed multiple sheet support. Reading up on your conversation, I was in agreement with you that it should be supported but shouldn't break existing syntax and should also allow additional sheets to be manipulated with the same ease.

All of your tests pass, and I've added two for the new features.

All of the existing methods on the exporter still work, but if you do withSheet( "Some OtherSheet"), you'll get back something (What is it? That's…slippery.) sharing the same API as the exporter itself. It basically works by changing your *Ability classes to @Category a new interface, having XlsxExporter implement this interface, and adding an ExcelExportSheet class that's basically a cheap, mixed-in wrapper for an individual sheet.

Syntax:

// First sheet
xlsxReporter.add(sheet1Objects, allPropertiesToBeAdded, 0)
// Work with a second sheet
xlsxReporter.withSheet('sheet2').add( sheet2Objects, allPropertiesToBeAdded, 0)

I also switched a bit up to let people change the name of the initial sheet:

If you want something other than "Report" for the first worksheet, set the worksheet name when you create the exporter:

namedSheetExporter = new XlsxExporter(worksheetName: otherSheetName)

I've also added/tested support for Maps instead of typed objects.

jakubnabrdalik commented 10 years ago

Nice job :+1:

I have a few tiny issues with the code, so before I merge it, I'll have to refactor it a bit, to keep the style of the whole project consistent. Or I can send you a code review if you are interested.

Can you add documentation to the readme?

joeRinehart commented 10 years ago

Hey man,

Please feel free to do what you want for consistency's sake. The only thing I ask is that it'd really help us if you left 'sheet' and 'workbook' properties public so that we can grab them if all else fails...

I've got some spare time today, so if you want to send a review, I can probably edit the readme and then knock stuff out.

brian428 commented 10 years ago

Jakub, just curious if you were planning to merge this in and release a new version?

jakubnabrdalik commented 10 years ago

Yeah, I did the merge with the latest master revision locally, and I'm working on refactoring. It takes so long, because I've changed my job in the mean time, but I should have it this done week.

2014/1/15 Brian Kotek notifications@github.com

Jakub, just curious if you were planning to merge this in and release a new version?

— Reply to this email directly or view it on GitHubhttps://github.com/TouK/excel-export/pull/15#issuecomment-32391465 .

Jakub Nabrdalik http://solidcraft.eu http://blog.solidcraft.eu

orlandobcrra commented 10 years ago

I miss this functionality, :+1:

jakubnabrdalik commented 10 years ago

0.2.0 released. Let me know if it works for you.