search

TouK / excel-export

excel-export grails plugin
58 stars 32 forks source link

adding the ability to handle other property types using .toString() instead of throw a exception #20

Closed orlandobcrra closed 10 years ago

orlandobcrra commented 10 years ago

Hi,

I've done a minor update to be able to get the String representation of an object instead of throw a exception. What do you think? Is there something else to update to be able to merge?

orlandobcrra commented 10 years ago

Hi @jakubnabrdalik ,

I just did another minor change in the Test to verify the ability to handle Enums with the new enhancement feature.

Regards,

jakubnabrdalik commented 10 years ago

Hi Orlando. It looks good. I'll test it in the evening with two different grails version and if all is fine, merge it. Thanks :+1:

orlandobcrra commented 10 years ago

Great, If everything is fine, could you also publish it into the grails repo? Thanks :)

jakubnabrdalik commented 10 years ago

Merged, pushed and published to grails plugin repo. Version 0.2.1.

The flag you've created should probably be in a different place (from the user perspective it was not intuitive to setup a static on some internal class), but I've removed throwing the IllegalArgumentException on unknown types instead. Every object has toString(), and we can always use that.

I've also updated sample project (https://github.com/TouK/excel-export-samples) and documentation.

Thank you.

orlandobcrra commented 10 years ago

That's great :) Thanks (Y)